Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abstract GPU kernels from the algorithm code #87

Closed
pelesh opened this issue Nov 29, 2023 · 2 comments
Closed

Abstract GPU kernels from the algorithm code #87

pelesh opened this issue Nov 29, 2023 · 2 comments
Assignees
Labels
cuda enhancement New feature or request hip

Comments

@pelesh
Copy link
Collaborator

pelesh commented Nov 29, 2023

Prototypes for GPU kernel wrappers should not depend on vendor-specific compiler. See comment below:

I don't think we should manage vendor specific includes at this level. The random sketching function should be hardware agnostic.

Originally posted by @pelesh in #83 (comment)

@pelesh
Copy link
Collaborator Author

pelesh commented Dec 12, 2023

@kswirydo, consider implementing FWHT kernels in a similar way we implemented VectorKernels (i.e. the vector kernel; we have only one here :)). The downside of this approach is we can build only one backend per build (i.e. cannot build HIP and CUDA at the same time).

Alternatively, we could use similar approach we used for handlers. That would be a little more work, but would be a more flexible solution.

@pelesh
Copy link
Collaborator Author

pelesh commented Mar 15, 2024

Addressed in #147

@pelesh pelesh closed this as completed Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cuda enhancement New feature or request hip
Projects
None yet
Development

No branches or pull requests

2 participants