Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vector initialization functions do not set "updated" flags correctly #216

Open
pelesh opened this issue Jan 23, 2025 · 0 comments
Open

Vector initialization functions do not set "updated" flags correctly #216

pelesh opened this issue Jan 23, 2025 · 0 comments
Assignees
@pelesh
Labels
bug Something isn't working
Milestone
Release 0.99.2

Comments

@pelesh
Copy link
Collaborator

pelesh commented Jan 23, 2025

Methods for vector initialization Vector::setToConst and Vector::setToZero do not set flags cpu_updated_ or gpu_updated_. This means that other functions would see the initialized memory space of vector as out of date and could overwrite it.

The fix is to call setDataUpdated method inside the initialization function.

CC @kswirydo
@pelesh pelesh added the bug Something isn't working label Jan 23, 2025
@pelesh pelesh self-assigned this Jan 23, 2025
@pelesh pelesh added this to the Release 0.99.2 milestone Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pelesh pelesh

Labels
bug Something isn't working
Projects
None yet
Milestone
Release 0.99.2
Development

No branches or pull requests
1 participant
@pelesh