From 8fcca3ebb861f0f36af2b3f2aff21b6034d1754d Mon Sep 17 00:00:00 2001 From: "Rutherford, Cameron" Date: Thu, 2 Nov 2023 16:04:01 -0400 Subject: [PATCH] Fix exported CMake bug in CXX_STANDARD --- CMakePresets.json | 2 +- cmake/ReSolveConfig.cmake.in | 4 ++++ examples/CMakeLists.txt | 3 +++ examples/resolve_consumer/CMakeLists.txt | 2 +- 4 files changed, 9 insertions(+), 2 deletions(-) diff --git a/CMakePresets.json b/CMakePresets.json index c00f99198..b1b890094 100644 --- a/CMakePresets.json +++ b/CMakePresets.json @@ -25,7 +25,7 @@ "installDir": "${sourceDir}/install", "generator": "Unix Makefiles" }, - { + { "name": "ascent", "inherits": "cuda", "displayName": "Ascent Build", diff --git a/cmake/ReSolveConfig.cmake.in b/cmake/ReSolveConfig.cmake.in index 47f9fe351..1e1fbfb06 100644 --- a/cmake/ReSolveConfig.cmake.in +++ b/cmake/ReSolveConfig.cmake.in @@ -4,6 +4,10 @@ include("${CMAKE_CURRENT_LIST_DIR}/ReSolveTargets.cmake") +if(NOT CMAKE_CXX_STANDARD) + set(CMAKE_CXX_STANDARD @CMAKE_CXX_STANDARD@) +endif() + include(CheckLanguage) # This must come before enable_language(CUDA) if(@RESOLVE_USE_CUDA@) diff --git a/examples/CMakeLists.txt b/examples/CMakeLists.txt index 9113ce170..faa538077 100644 --- a/examples/CMakeLists.txt +++ b/examples/CMakeLists.txt @@ -71,8 +71,11 @@ set(CONSUMER_PATH ${CMAKE_INSTALL_PREFIX}/share/examples) install(PROGRAMS test.sh DESTINATION ${CONSUMER_PATH}) # Select consumer app +# TODO - have an outer loop that adds a unique consumer test for each backend supproted if(RESOLVE_USE_CUDA) set(RESOLVE_CONSUMER_APP "testKLU_Rf_FGMRES.cpp") +elseif(RESOLVE_USE_HIP) + set(RESOLVE_CONSUMER_APP "testKLU_RocSolver.cpp") else() set(RESOLVE_CONSUMER_APP "testKLU.cpp") endif() diff --git a/examples/resolve_consumer/CMakeLists.txt b/examples/resolve_consumer/CMakeLists.txt index e03a4e6f0..063701193 100644 --- a/examples/resolve_consumer/CMakeLists.txt +++ b/examples/resolve_consumer/CMakeLists.txt @@ -11,7 +11,7 @@ find_package(ReSolve REQUIRED) # Build example with KLU factorization and KLU refactorization add_executable(consume.exe consumer.cpp) -target_link_libraries(consume.exe PRIVATE ReSolve::ReSolve) +target_link_libraries(consume.exe PUBLIC ReSolve::ReSolve) #------------------------------------------------------------------------------------ # Testing of exported Resolve Configurations