Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSK and TSK lengths #159

Open
railabouni opened this issue May 31, 2022 · 4 comments
Open

SSK and TSK lengths #159

railabouni opened this issue May 31, 2022 · 4 comments
Labels
enhancement New feature or request

Comments

@railabouni
Copy link

Hi,
in https://github.com/OP-TEE/optee_docs/blame/master/architecture/secure_storage.rst#L344 SSK and TSK are 128-bit while each of them is a result of HMAC-SHA256 (should be 256-bit long each)
What am I missing?

Thank you!

@jbech-linaro
Copy link
Contributor

The key comes from the HMAC-SHA256 as you're saying, but it is truncated to a 128-bit key here (called from here and the define is here).

@jbech-linaro
Copy link
Contributor

But I agree, the docs are a bit unclear here. Should be updated to reflect what actually is happening without making assumptions.

@railabouni
Copy link
Author

railabouni commented May 31, 2022

yea, was a bit confused cause in: https://github.com/OP-TEE/optee_docs/blame/master/architecture/secure_storage.rst#L362
did say "128 bits of k" after "k = SHA256(FEK);" :)

Thank you! Joakim

@github-actions
Copy link

github-actions bot commented Jul 1, 2022

This issue has been marked as a stale issue because it has been open (more than) 30 days with no activity. Remove the stale label or add a comment, otherwise this issue will automatically be closed in 5 days. Note, that you can always re-open a closed issue at any time.

@github-actions github-actions bot added the Stale label Jul 1, 2022
@jbech-linaro jbech-linaro added enhancement New feature or request and removed Stale labels Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants