Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move functions outside train() to improve performance #113

Open
facusapienza21 opened this issue Oct 12, 2024 · 0 comments
Open

Move functions outside train() to improve performance #113

facusapienza21 opened this issue Oct 12, 2024 · 0 comments
Assignees
@facusapienza21
Labels
enhancement New feature or request

Comments

@facusapienza21
Copy link
Member

Right now all is implemented inside the train.jl module using global variables, which I don't think is very efficient... we should move function definition outside and make all more modular. Hopefully, this will have a positive impact in performance.
@facusapienza21 facusapienza21 added the enhancement New feature or request label Oct 12, 2024
@facusapienza21 facusapienza21 self-assigned this Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@facusapienza21 facusapienza21

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@facusapienza21