[18.0][MIG] crm_team_parent

Author: sbejaoui

crm_team_parent/README.rst

@@ -17,19 +17,20 @@ Crm Team Parent
     :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html
     :alt: License: AGPL-3
 .. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fcrm-lightgray.png?logo=github
-    :target: https://github.com/OCA/crm/tree/12.0/crm_team_parent
+    :target: https://github.com/OCA/crm/tree/18.0/crm_team_parent
     :alt: OCA/crm
 .. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png
-    :target: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-crm_team_parent
+    :target: https://translation.odoo-community.org/projects/crm-18-0/crm-18-0-crm_team_parent
     :alt: Translate me on Weblate
 .. |badge5| image:: https://img.shields.io/badge/runboat-Try%20me-875A7B.png
-    :target: https://runboat.odoo-community.org/builds?repo=OCA/crm&target_branch=12.0
+    :target: https://runboat.odoo-community.org/builds?repo=OCA/crm&target_branch=18.0
     :alt: Try me on Runboat
 
 |badge1| |badge2| |badge3| |badge4| |badge5|
 
-This module adds a 'Parent Team' field on the Sales Team form. This field is also displayed in the Sales Teams list.
-Plus, a constraint check is performed in order to avoid loops in the hierarchy.
+This module adds a 'Parent Team' field on the Sales Team form. This
+field is also displayed in the Sales Teams list. Plus, a constraint
+check is performed in order to avoid loops in the hierarchy.
 
 **Table of contents**
 
@@ -41,35 +42,35 @@ Usage
 
 To use this module, you need to:
 
-#. Go to *CRM > Configuration > Sales Teams*.
-#. Create/edit a sales team.
-#. The parent team will be checked for loop in the hierarchy.
+1. Go to *CRM > Configuration > Sales Teams*.
+2. Create/edit a sales team.
+3. The parent team will be checked for loop in the hierarchy.
 
 Bug Tracker
 ===========
 
 Bugs are tracked on `GitHub Issues <https://github.com/OCA/crm/issues>`_.
 In case of trouble, please check there if your issue has already been reported.
 If you spotted it first, help us to smash it by providing a detailed and welcomed
-`feedback <https://github.com/OCA/crm/issues/new?body=module:%20crm_team_parent%0Aversion:%2012.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
+`feedback <https://github.com/OCA/crm/issues/new?body=module:%20crm_team_parent%0Aversion:%2018.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
 
 Do not contact contributors directly about support or help with technical issues.
 
 Credits
 =======
 
 Authors
-~~~~~~~
+-------
 
 * ACSONE SA/NV
 
 Contributors
-~~~~~~~~~~~~
+------------
 
-* Quentin Groulard <[email protected]>
+-  Quentin Groulard <[email protected]>
 
 Maintainers
-~~~~~~~~~~~
+-----------
 
 This module is maintained by the OCA.
 
@@ -81,6 +82,6 @@ OCA, or the Odoo Community Association, is a nonprofit organization whose
 mission is to support the collaborative development of Odoo features and
 promote its widespread use.
 
-This module is part of the `OCA/crm <https://github.com/OCA/crm/tree/12.0/crm_team_parent>`_ project on GitHub.
+This module is part of the `OCA/crm <https://github.com/OCA/crm/tree/18.0/crm_team_parent>`_ project on GitHub.
 
 You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute.

crm_team_parent/__manifest__.py

@@ -5,7 +5,7 @@
     "name": "Crm Team Parent",
     "summary": """
         Add a parent field on sales teams.""",
-    "version": "12.0.1.0.1",
+    "version": "18.0.1.0.0",
     "license": "AGPL-3",
     "author": "ACSONE SA/NV,Odoo Community Association (OCA)",
     "website": "https://github.com/OCA/crm",

crm_team_parent/models/crm_team.py

@@ -1,16 +1,10 @@
 # Copyright 2018 ACSONE SA/NV
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
 
-from odoo import api, fields, models, _
-from odoo.exceptions import ValidationError
-
-
-class ParentLoopError(ValidationError):
-    pass
+from odoo import fields, models
 
 
 class CrmTeam(models.Model):
-
     _inherit = "crm.team"
     _parent_store = True
     parent_path = fields.Char(index=True)
@@ -20,21 +14,3 @@ class CrmTeam(models.Model):
         inverse_name="parent_id",
         string="Children team",
     )
-
-    @api.constrains("parent_id")
-    def _constrains_parent_id(self):
-        def _check_for_loop(new_child, current):
-            if not current.parent_id:
-                return True
-            if current.parent_id == new_child:
-                return False
-            return _check_for_loop(new_child, current.parent_id)
-
-        for rec in self.filtered("parent_id"):
-            if not _check_for_loop(rec, rec):
-                raise ParentLoopError(
-                    _(
-                        "Wrong Parent Team: "
-                        "No loop allowed in the teams' hierarchy."
-                    )
-                )

crm_team_parent/pyproject.toml

@@ -0,0 +1,3 @@
+[build-system]
+requires = ["whool"]
+build-backend = "whool.buildapi"

crm_team_parent/readme/CONTRIBUTORS.md

@@ -0,0 +1 @@
+- Quentin Groulard \<<[email protected]>\>

crm_team_parent/readme/CONTRIBUTORS.rst

@@ -0,0 +1,3 @@
+This module adds a 'Parent Team' field on the Sales Team form. This
+field is also displayed in the Sales Teams list. Plus, a constraint
+check is performed in order to avoid loops in the hierarchy.

crm_team_parent/readme/DESCRIPTION.md

@@ -0,0 +1,5 @@
+To use this module, you need to:
+
+1.  Go to *CRM \> Configuration \> Sales Teams*.
+2.  Create/edit a sales team.
+3.  The parent team will be checked for loop in the hierarchy.