[MIG] srm: Migration to 18.0

Author: vvrossem

srm/__manifest__.py

@@ -4,7 +4,7 @@
 
 {
     "name": "SRM",
-    "version": "14.0.1.0.0",
+    "version": "18.0.1.0.0",
     "author": "Camptocamp, Odoo Community Association (OCA)",
     "summary": "Use CRM model for suppliers",
     "license": "AGPL-3",
@@ -14,7 +14,6 @@
         "crm",
         "sale_crm",
         "purchase",
-        "crm_enterprise",
     ],
     "website": "https://github.com/OCA/crm",
     "data": [

srm/views/crm_lead_views.xml

@@ -16,18 +16,4 @@
                 'search_default_assigned_to_me': 1,
         }</field>
     </record>
-
-    <!-- dashboard action -->
-    <record id="crm_enterprise.crm_lead_action_dashboard" model="ir.actions.act_window">
-        <field
-            name="domain"
-        >['&amp;', ('request_type','in',(False,'customer')), '|', ('active','=',True), ('active','=',False)]</field>
-    </record>
-
-    <record
-        id="crm_enterprise.crm_opportunity_action_dashboard"
-        model="ir.actions.act_window"
-    >
-        <field name="domain">[('request_type','in',(False,'customer'))]</field>
-    </record>
 </odoo>

srm/views/srm_lead_views.xml

@@ -24,7 +24,7 @@
                 <field
                     name="partner_id"
                     string="Supplier"
-                    attrs="{'invisible': [('request_type','=','customer')]}"
+                    invisible="request_type == 'customer'"
                 />
             </xpath>
             <xpath
@@ -34,7 +34,7 @@
                 <field
                     name="partner_id"
                     string="Customer"
-                    attrs="{'invisible': [('request_type','!=','customer')]}"
+                    invisible="request_type != 'customer'"
                 />
             </xpath>
             <field name="user_id" position="attributes">
@@ -52,8 +52,7 @@
         <field name="view_mode">form</field>
         <field
             name="context"
-        >{'search_default_partner_id': active_id, 'default_partner_id': active_id}</field>
-        <field name="groups_id" eval="[(4, ref('purchase.group_purchase_user'))]" />
+        >{'search_default_partner_id': id, 'default_partner_id': id}</field>
     </record>
 
     <record id="crm_case_form_view_oppor" model="ir.ui.view">
@@ -65,34 +64,44 @@
                 expr="//button[@name='action_sale_quotations_new']"
                 position="attributes"
             >
+                <!-- addition to `type == 'lead' or probability == 0 and not active` -->
                 <attribute
-                    name="attrs"
-                >{'invisible': ['|', ('request_type', '=', 'supplier'), '|', ('type', '=', 'lead'), '&amp;', ('probability', '=', 0), ('active', '=', False)]}</attribute>
+                    name="invisible"
+                    add="request_type == 'supplier'"
+                    separator="or"
+                />
             </xpath>
             <xpath expr="//button[@name='action_set_won_rainbowman']" position="before">
                 <button
                     string="New RFQ"
                     name="action_lead_rfq_new"
                     type="object"
                     class="oe_highlight"
-                    attrs="{'invisible': ['|', ('request_type', '!=', 'supplier'), '|', ('type', '=', 'lead'), '&amp;', ('probability', '=', 0), ('active', '=', False)]}"
+                    invisible="request_type != 'supplier' or type == 'lead' or (probability == 0 and not active)"
+                    groups="purchase.group_purchase_user"
                 />
             </xpath>
             <xpath
                 expr="//button[@name='action_view_sale_quotation']"
                 position="attributes"
             >
+                <!-- addition to `type == 'lead'` -->
                 <attribute
-                    name="attrs"
-                >{'invisible': ['|', ('request_type', '=', 'supplier'), ('type', '=', 'lead')]}</attribute>
+                    name="invisible"
+                    add="request_type == 'supplier'"
+                    separator="or"
+                />
             </xpath>
             <xpath
                 expr="//button[@name='action_view_sale_order']"
                 position="attributes"
             >
+                <!-- addition to `sale_order_count == 0 or type == 'lead'` -->
                 <attribute
-                    name="attrs"
-                >{'invisible': ['|', '|', ('request_type', '=', 'supplier'), ('sale_order_count', '=', 0), ('type', '=', 'lead')]}</attribute>
+                    name="invisible"
+                    add="request_type == 'supplier'"
+                    separator="or"
+                />
             </xpath>
 
             <button name="action_schedule_meeting" position="after">
@@ -101,7 +110,7 @@
                     type="object"
                     name="action_view_sale_quotation"
                     icon="fa-pencil-square-o"
-                    attrs="{'invisible': [('type', '=', 'lead')]}"
+                    invisible="type == 'lead'"
                 >
                     <field
                         name="request_for_quotation_count"
@@ -112,7 +121,7 @@
                 <button
                     class="oe_stat_button"
                     type="object"
-                    attrs="{'invisible': ['|', ('purchase_amount_total', '=', 0), ('type', '=', 'lead')]}"
+                    invisible="purchase_amount_total == 0 or type == 'lead'"
                     name="action_view_sale_order"
                     icon="fa-usd"
                 >
@@ -146,7 +155,7 @@
     <record id="srm_lead_action_pipeline" model="ir.actions.act_window">
         <field name="name">Srm: Pipeline</field>
         <field name="res_model">crm.lead</field>
-        <field name="view_mode">kanban,tree,graph,pivot,form,calendar,activity</field>
+        <field name="view_mode">kanban,list,graph,pivot,form,calendar,activity</field>
         <field
             name="domain"
         >[('type','=','opportunity'), ('request_type','=', 'supplier')]</field>
@@ -162,7 +171,6 @@
         <field name="name">Srm: My Pipeline</field>
         <field name="model_id" ref="crm.model_crm_team" />
         <field name="state">code</field>
-        <field name="groups_id" eval="[(4, ref('base.group_user'))]" />
         <field
             name="code"
         >action = model.with_context(request_type='supplier').action_your_pipeline()</field>
@@ -172,7 +180,7 @@
     <record id="srm_lead_all_leads" model="ir.actions.act_window">
         <field name="name">Leads</field>
         <field name="res_model">crm.lead</field>
-        <field name="view_mode">tree,kanban,graph,pivot,calendar,form,activity</field>
+        <field name="view_mode">list,kanban,graph,pivot,calendar,form,activity</field>
         <field
             name="domain"
         >['&amp;','|', ('type','=','lead'), ('type','=',False), ('request_type', '=', 'supplier')]</field>
@@ -190,7 +198,7 @@
     <record id="srm_lead_action_dashboard" model="ir.actions.act_window">
         <field name="name">Srm Leads Analysis</field>
         <field name="res_model">crm.lead</field>
-        <field name="view_mode">dashboard,pivot,graph,tree</field>
+        <field name="view_mode">pivot,graph,list</field>
         <field
             name="domain"
         >['&amp;', ('request_type','=', 'supplier'),  '|', ('active','=',True), ('active','=',False)]</field>
@@ -201,17 +209,17 @@
     <record id="srm_opportunity_action_dashboard" model="ir.actions.act_window">
         <field name="name">Pipeline Analysis</field>
         <field name="res_model">crm.lead</field>
-        <field name="view_mode">dashboard,pivot,graph,tree,form,cohort</field>
+        <field name="view_mode">pivot,graph,list,form,cohort</field>
         <field name="domain">[('request_type','=', 'supplier')]</field>
         <field
             name="context"
             eval="{
-            'tree_view_ref': 'crm.crm_case_tree_view_oppor',
+            'list_view_ref': 'crm.crm_case_tree_view_oppor',
             'default_type': 'opportunity',
             'search_default_opportunity': True,
             'search_default_filter_create_date': 1}"
         />
-        <field name="search_view_id" ref="crm_enterprise.crm_opportunity_view_search" />
+        <field name="search_view_id" ref="crm.crm_opportunity_report_view_search" />
     </record>
 
     <!-- menuitem -->
@@ -233,5 +241,6 @@
 
     <record id="menu_srm_opportunities" model="ir.ui.menu">
         <field name="action" ref="srm.action_your_pipeline" />
+        <field name="groups_id" eval="[Command.link(ref('base.group_user'))]" />
     </record>
 </odoo>

srm/wizard/srm_opportunity_to_rfq.py

@@ -1,7 +1,7 @@
 # Copyright 2022 Camptocamp SA
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html)
 
-from odoo import _, api, fields, models
+from odoo import api, fields, models
 from odoo.exceptions import UserError
 
 
@@ -15,7 +15,7 @@ def default_get(self, fields):
 
         active_model = self._context.get("active_model")
         if active_model != "crm.lead":
-            raise UserError(_("You can only apply this action from a lead."))
+            raise UserError(self.env._("You can only apply this action from a lead."))
 
         lead = False
         if result.get("lead_id"):

srm/wizard/srm_opportunity_to_rfq_views.xml

@@ -11,13 +11,12 @@
                         <field name="lead_id" invisible="1" />
                     </group>
                 </group>
-                <group
-                    attrs="{'invisible': [('action','!=','exist')], 'required':[('action', '=','exist')]}"
-                >
+                <group invisible="action != 'exist'" required="action == 'exist'">
                     <group>
                         <field
                             name="partner_id"
-                            attrs="{'invisible': [('action','!=','exist')], 'required':[('action', '=','exist')]}"
+                            invisible="action != 'exist'"
+                            required="action == 'exist'"
                             context="{'res_partner_search_mode': 'supplier'}"
                         />
                     </group>