Skip to content

Commit 57f13da

Browse files
Merge pull request #288 from OBOFoundry/revised
COB Revised -- Wait for James to Merge
2 parents 0787b2f + 4bb8a41 commit 57f13da

17 files changed

+2375
-9662
lines changed

cob-base.owl

Lines changed: 175 additions & 2738 deletions
Large diffs are not rendered by default.

cob-full.owl

Lines changed: 0 additions & 1456 deletions
This file was deleted.

cob-root.owl

Lines changed: 1369 additions & 0 deletions
Large diffs are not rendered by default.

cob.owl

Lines changed: 460 additions & 605 deletions
Large diffs are not rendered by default.

cob.tsv

Lines changed: 62 additions & 68 deletions
Large diffs are not rendered by default.

docs/odk-workflows/RepositoryFileStructure.md

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,6 @@ These are the current imports in COB
1616

1717
| Import | URL | Type |
1818
| ------ | --- | ---- |
19-
| ro | http://purl.obolibrary.org/obo/ro.owl | custom |
20-
| omo | http://purl.obolibrary.org/obo/omo.owl | mirror |
2119

2220
## Components
2321
Components, in contrast to imports, are considered full members of the ontology. This means that any axiom in a component is also included in the ontology base - which means it is considered _native_ to the ontology. While this sounds complicated, consider this: conceptually, no component should be part of more than one ontology. If that seems to be the case, we are most likely talking about an import. Components are often not needed for ontologies, but there are some use cases:
@@ -26,9 +24,4 @@ Components, in contrast to imports, are considered full members of the ontology.
2624
2. A part of the ontology is managed in ROBOT templates
2725
3. The expressivity of the component is higher than the format of the edit file. For example, people still choose to manage their ontology in OBO format (they should not) missing out on a lot of owl features. They may choose to manage logic that is beyond OBO in a specific OWL component.
2826

29-
These are the components in COB
3027

31-
| Filename | URL |
32-
| -------- | --- |
33-
| cob-annotations.owl | None |
34-
| cob-to-external.owl | None |

src/ontology/Makefile

Lines changed: 4 additions & 72 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
# 6. [Run everything (COB products and release pipeline)](all)
2020

2121
# Fingerprint of the configuration file when this Makefile was last generated
22-
CONFIG_HASH= 5daef41d99e802417bd9ad0f378f72168e2d30f0488f5b2423330cbc561ec834
22+
CONFIG_HASH= 0cb0824fc712dd1bbe3e3067c8a9d6d4212a769da65f9ec96e0020e31e2cafb9
2323

2424

2525
# ----------------------------------------
@@ -62,13 +62,13 @@ OBODATE ?= $(shell date +'%d:%m:%Y %H:%M')
6262
VERSION= $(TODAY)
6363
ANNOTATE_ONTOLOGY_VERSION = annotate -V $(ONTBASE)/releases/$(VERSION)/$@ --annotation owl:versionInfo $(VERSION)
6464
ANNOTATE_CONVERT_FILE = annotate --ontology-iri $(ONTBASE)/$@ $(ANNOTATE_ONTOLOGY_VERSION) convert -f ofn --output $@.tmp.owl && mv $@.tmp.owl $@
65-
OTHER_SRC = $(COMPONENTSDIR)/cob-annotations.owl $(COMPONENTSDIR)/cob-to-external.owl
65+
OTHER_SRC =
6666
ONTOLOGYTERMS = $(TMPDIR)/ontologyterms.txt
6767
EDIT_PREPROCESSED = $(TMPDIR)/$(ONT)-preprocess.owl
6868

6969
FORMATS = $(sort owl owl)
7070
FORMATS_INCL_TSV = $(sort $(FORMATS) tsv)
71-
RELEASE_ARTEFACTS = $(sort $(ONT)-base $(ONT)-full cob-base-reasoned cob-examples-reasoned cob-native )
71+
RELEASE_ARTEFACTS = $(sort $(ONT)-base $(ONT)-root )
7272

7373
ifeq ($(ODK_DEBUG),yes)
7474
ODK_DEBUG_FILE = debug.log
@@ -168,7 +168,7 @@ all_main: $(MAIN_FILES)
168168
# ----------------------------------------
169169

170170

171-
IMPORTS = ro omo
171+
IMPORTS =
172172

173173
IMPORT_ROOTS = $(patsubst %, $(IMPORTDIR)/%_import, $(IMPORTS))
174174
IMPORT_OWL_FILES = $(foreach n,$(IMPORT_ROOTS), $(n).owl)
@@ -375,16 +375,6 @@ $(IMPORTDIR)/%_import.owl: $(MIRRORDIR)/%.owl $(IMPORTDIR)/%_terms_combined.txt
375375

376376
.PRECIOUS: $(IMPORTDIR)/%_import.owl
377377

378-
## Module for ontology: ro
379-
380-
$(IMPORTDIR)/ro_import.owl: $(MIRRORDIR)/ro.owl
381-
echo "ERROR: You have configured your default module type to be custom; this behavior needs to be overwritten in cob.Makefile!" && false
382-
## Module for ontology: omo
383-
384-
$(IMPORTDIR)/omo_import.owl: $(MIRRORDIR)/omo.owl $(IMPORTDIR)/omo_terms_combined.txt
385-
if [ $(IMP) = true ]; then $(ROBOT) merge -i $< query --update ../sparql/preprocess-module.ru --update ../sparql/inject-subset-declaration.ru --update ../sparql/inject-synonymtype-declaration.ru --update ../sparql/postprocess-module.ru \
386-
$(ANNOTATE_CONVERT_FILE); fi
387-
388378

389379
.PHONY: refresh-imports
390380
refresh-imports:
@@ -406,39 +396,6 @@ refresh-%:
406396
no-mirror-refresh-%:
407397
$(MAKE) IMP=true IMP_LARGE=true MIR=false PAT=false $(IMPORTDIR)/$*_import.owl -B
408398

409-
410-
# ----------------------------------------
411-
# Components
412-
# ----------------------------------------
413-
# Some ontologies contain external and internal components. A component is included in the ontology in its entirety.
414-
415-
COMP=true # Global parameter to bypass component generation
416-
417-
.PHONY: all_components
418-
all_components: $(OTHER_SRC)
419-
420-
.PHONY: recreate-components
421-
recreate-components:
422-
$(MAKE) COMP=true IMP=false MIR=true PAT=true IMP_LARGE=false all_components -B
423-
424-
.PHONY: no-mirror-recreate-components
425-
no-mirror-recreate-components:
426-
$(MAKE) COMP=true IMP=false MIR=false PAT=true IMP_LARGE=false all_components -B
427-
428-
.PHONY: recreate-%
429-
recreate-%:
430-
$(MAKE) COMP=true IMP=false IMP_LARGE=false MIR=true PAT=true $(COMPONENTSDIR)/$*.owl -B
431-
432-
.PHONY: no-mirror-recreate-%
433-
no-mirror-recreate-%:
434-
$(MAKE) COMP=true IMP=false IMP_LARGE=false MIR=false PAT=true $(COMPONENTSDIR)/$*.owl -B
435-
436-
$(COMPONENTSDIR)/%.owl: | $(COMPONENTSDIR)
437-
test -f $@ || touch $@
438-
.PRECIOUS: $(COMPONENTSDIR)/%.owl
439-
440-
441-
442399
# ----------------------------------------
443400
# Mirroring upstream ontologies
444401
# ----------------------------------------
@@ -450,22 +407,6 @@ IMP_LARGE=true # Global parameter to bypass handling of large imports
450407
ifeq ($(strip $(MIR)),true)
451408

452409

453-
## ONTOLOGY: ro
454-
.PHONY: mirror-ro
455-
.PRECIOUS: $(MIRRORDIR)/ro.owl
456-
mirror-ro: | $(TMPDIR)
457-
curl -L $(OBOBASE)/ro.owl --create-dirs -o $(TMPDIR)/ro-download.owl --retry 4 --max-time 200 && \
458-
$(ROBOT) convert -i $(TMPDIR)/ro-download.owl -o $(TMPDIR)/$@.owl
459-
460-
461-
## ONTOLOGY: omo
462-
.PHONY: mirror-omo
463-
.PRECIOUS: $(MIRRORDIR)/omo.owl
464-
mirror-omo: | $(TMPDIR)
465-
curl -L $(OBOBASE)/omo.owl --create-dirs -o $(TMPDIR)/omo-download.owl --retry 4 --max-time 200 && \
466-
$(ROBOT) convert -i $(TMPDIR)/omo-download.owl -o $(TMPDIR)/$@.owl
467-
468-
469410
$(MIRRORDIR)/%.owl: mirror-% | $(MIRRORDIR)
470411
if [ -f $(TMPDIR)/mirror-$*.owl ]; then if cmp -s $(TMPDIR)/mirror-$*.owl $@ ; then echo "Mirror identical, ignoring."; else echo "Mirrors different, updating." &&\
471412
cp $(TMPDIR)/mirror-$*.owl $@; fi; fi
@@ -549,15 +490,6 @@ $(ONT)-full.owl: $(EDIT_PREPROCESSED) $(OTHER_SRC) $(IMPORT_FILES)
549490
relax \
550491
reduce -r ELK \
551492
$(SHARED_ROBOT_COMMANDS) annotate --ontology-iri $(ONTBASE)/$@ $(ANNOTATE_ONTOLOGY_VERSION) --output $@.tmp.owl && mv $@.tmp.owl $@
552-
553-
cob-base-reasoned.owl:
554-
echo "ERROR: You have configured a custom release artefact ($@); this release artefact needs to be define in cob.Makefile!" && false
555-
556-
cob-examples-reasoned.owl:
557-
echo "ERROR: You have configured a custom release artefact ($@); this release artefact needs to be define in cob.Makefile!" && false
558-
559-
cob-native.owl:
560-
echo "ERROR: You have configured a custom release artefact ($@); this release artefact needs to be define in cob.Makefile!" && false
561493
# ----------------------------------------
562494
# Debugging Tools
563495
# ----------------------------------------

0 commit comments

Comments
 (0)