Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing syntax of security in TicTacToe OpenAPI example #84

Closed
wants to merge 2 commits into from

Conversation

karelhusa
Copy link

The provided tictactoe.yaml OpenAPI example is not valid and fails to be rendered in Redocly.

Security element's type is an array. I have fixed the syntax in security of the operations.

khusa added 2 commits February 16, 2024 07:53
…in Redocly.

Fixed syntax in application of security to the operations. Security is an array.
…t respect the differences in the operation security (as was previously).
@lornajane lornajane self-requested a review February 24, 2024 19:43
@lornajane
Copy link
Collaborator

Thanks for spotting and fixing this @karelhusa, these should indeed be array elements.

I have one question about the security on the get-board operation though, looking at the docs it seems like the keys in security array for an operation should be reflected in the components.securitySchemes - so should this be defaultApiKey here?

@handrews
Copy link
Member

handrews commented Jun 3, 2024

PR #102 has incorporated this fix, so between that and the lack of reply for a few months I'm going to close this PR in favor of that one. But thank you for submitting it as it helped spot an error in the other PR's version of this!

@handrews handrews closed this Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants