openimagedenoise: 1.2.2 -> 1.3.0

[erictapen]

Motivation for this change

Things done

Also switched to python3, which seems to build flawlessly.

This depends on #118418, as our current ispc version is too old.

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Ensured that relevant documentation is up to date
• Fits CONTRIBUTING.md.

[erictapen]

Rebased ontop of master, as that was confusing, having the commit of another PR in this one. Note that this doesn't build until #118418 is merged.

[r-rmcgibbo]

Result of nixpkgs-review pr 118419 at 57cb8a61 run on x86_64-linux 1

2 packages failed to build:

• luxcorerender
• openimagedenoise

1 package skipped due to time constraints:

• blender

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement.

[risicle]

@ofborg build openimagedenoise blender

[erictapen]

@ofborg build openimagedenoise blender

[SuperSandro2000]

@ofborg eval

[risicle]

WFM macos 10.14

[SuperSandro2000]

luxcorerender:

       > Package mount was not found in the pkg-config search path.
       > Perhaps you should add the directory containing `mount.pc'
       > to the PKG_CONFIG_PATH environment variable
       > Package 'mount', required by 'gio-2.0', not found
       > Package mount was not found in the pkg-config search path.
       > Perhaps you should add the directory containing `mount.pc'
       > to the PKG_CONFIG_PATH environment variable
       > Package 'mount', required by 'gio-2.0', not found
       > Package mount was not found in the pkg-config search path.
       > Perhaps you should add the directory containing `mount.pc'
       > to the PKG_CONFIG_PATH environment variable
       > Package 'mount', required by 'gio-2.0', not found
       > Package mount was not found in the pkg-config search path.
       > Perhaps you should add the directory containing `mount.pc'
       > to the PKG_CONFIG_PATH environment variable
       > Package 'mount', required by 'gio-2.0', not found
       > -- Found BISON: /nix/store/ybl3zad6ihv60d4w0nprcj5a9g94z1z3-bison-3.7.6/bin/bison (found version "3.7.6")
       > -- Found FLEX: /nix/store/qrq8px6m7v85j9jcp7zzk1pkawmrll43-flex-2.6.4/bin/flex (found version "2.6.4")
       > CMake Error at CMakeLists.txt:119 (MESSAGE):
       >   --> Could not locate required Intel Oidn files - Please check
       >
       >
       > -- Configuring incomplete, errors occurred!
       > See also "/build/source/build/CMakeFiles/CMakeOutput.log".
       > See also "/build/source/build/CMakeFiles/CMakeError.log".
       For full logs, run 'nix log /nix/store/qkfq09dc8jcpwa8jyrgs5m0zm1cxla4n-luxcorerender-2.4.drv'.

[erictapen]

Well luxcorerender doesn't seem to support openimagedenoise above 1.2.1. Neither using the latest luxcorerender commit nor adding the patch of the linked PR fixes the build.

Pinging luxcorerender maintainer @Hodapp87, maybe they have an idea?

[SuperSandro2000]

Well luxcorerender doesn't seem to support openimagedenoise above 1.2.1. Neither using the latest luxcorerender commit nor adding the patch of the linked PR fixes the build.

We could split off openimagedenoise 1.2.X and keep it until it is required or override the version in luxcorerender if it is the only package that needs an older version.

[erictapen]

I just created a separate package openimagedenoise_1_2_x to use for luxcorerender. It is somewhat redudant atm, but I guess this is the cleanest solution: the latest version can adapt without regard to 1_2_x and if it eventually becomes obsolete, we just have to delete one file.

[SuperSandro2000]

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 118419 run on x86_64-linux 1

4 packages built:

• blender
• luxcorerender
• openimagedenoise
• openimagedenoise_1_2_x