replace tlp with power-profiles-daemon

TLP is often no longer the best choice since firmware provides power
profiles instead. That's why we are removing TLP as the default option.
We may want to bring back TLP to some old hardware if it makes sense
i.e. certain thinkpad modules.

Author: Mic92

asus/fa507nv/default.nix

@@ -22,10 +22,6 @@
   # Workaround for SuspendThenHibernate: https://lore.kernel.org/linux-kernel/[email protected]/
   boot.kernelParams = lib.optionals (lib.versionOlder config.boot.kernelPackages.kernel.version "6.8") ["rtc_cmos.use_acpi_alarm=1"];
 
-  # AMD has better battery life with PPD over TLP:
-  # https://community.frame.work/t/responded-amd-7040-sleep-states/38101/13
-  services.power-profiles-daemon.enable = lib.mkDefault true;
-
   # Adds the missing asus functionality to Linux.
   # https://asus-linux.org/manual/asusctl-manual/
   services = {

common/pc/laptop/default.nix

@@ -1,11 +1,5 @@
-{ config, lib, ... }:
-
-{
+{ lib, config, ... }: {
   imports = [ ../. ];
 
-  # Gnome 40 introduced a new way of managing power, without tlp.
-  # However, these 2 services clash when enabled simultaneously.
-  # https://github.com/NixOS/nixos-hardware/issues/260
-  services.tlp.enable = lib.mkDefault ((lib.versionOlder (lib.versions.majorMinor lib.version) "21.05")
-                                       || !config.services.power-profiles-daemon.enable);
+  config.services.power-profiles-daemon.enable = lib.mkDefault config.services.tlp.enable.enable;
 }

dell/inspiron/14-5420/README.md

@@ -8,6 +8,3 @@
 `fwupd` is used to receive firmware updates from vendors. This device is in its [supported devices list](https://fwupd.org/lvfs/devices/)
 
 `thermald` is used to achieve better thermal behaviour
-
-##### TLP
-TLP is a battery power optimizer for laptops. It is enabled by default, however, since it conflicts with power-profiles-daemon which is GNOME's power management system, TLP will not be installed with if power-profiles-daemon or a recent version of GNOME is present.

framework/13-inch/common/amd.nix

@@ -16,8 +16,4 @@
     ]
     # Workaround for SuspendThenHibernate: https://lore.kernel.org/linux-kernel/[email protected]/
     ++ lib.optionals (lib.versionOlder config.boot.kernelPackages.kernel.version "6.8") ["rtc_cmos.use_acpi_alarm=1"];
-
-  # AMD has better battery life with PPD over TLP:
-  # https://community.frame.work/t/responded-amd-7040-sleep-states/38101/13
-  services.power-profiles-daemon.enable = lib.mkDefault true;
 }

framework/16-inch/common/amd.nix

@@ -16,8 +16,4 @@
     ]
     # Workaround for SuspendThenHibernate: https://lore.kernel.org/linux-kernel/[email protected]/
     ++ lib.optionals (lib.versionOlder config.boot.kernelPackages.kernel.version "6.8") ["rtc_cmos.use_acpi_alarm=1"];
-
-  # AMD has better battery life with PPD over TLP:
-  # https://community.frame.work/t/responded-amd-7040-sleep-states/38101/13
-  services.power-profiles-daemon.enable = lib.mkDefault true;
 }

gpd/win-2/default.nix

@@ -10,9 +10,6 @@
     "video=eDP-1:panel_orientation=right_side_up"
   ];
 
-  services.tlp.enable = lib.mkDefault ((lib.versionOlder (lib.versions.majorMinor lib.version) "21.05")
-                                       || !config.services.power-profiles-daemon.enable);
-
   # Required for grub to properly display the boot menu.
   boot.loader.grub.gfxmodeEfi = lib.mkDefault "720x1280x32";
 

lenovo/ideapad/15arh05/default.nix

@@ -17,9 +17,4 @@
 
   # Cooling management
   services.thermald.enable = lib.mkDefault true;
-
-  # tlp defaults to "powersave", which doesn't exist on this laptop
-  services.tlp.settings = {
-    CPU_SCALING_GOVERNOR_ON_BAT = "schedutil";
-  };
 }

lenovo/legion/16aph8/default.nix

@@ -32,8 +32,4 @@
 
   # Avoid issues with modesetting causing blank screen
   services.xserver.videoDrivers = [ "nvidia" ];
-
-  # AMD has better battery life with PPD over TLP:
-  # https://community.frame.work/t/responded-amd-7040-sleep-states/38101/13
-  services.power-profiles-daemon.enable = lib.mkDefault true;
 }

microsoft/surface/common/default.nix

@@ -28,7 +28,7 @@ let
       "6.14.2"
     else
       abort "Invalid kernel version: ${kernelVersion}";
-  
+
   pkgHash = with config.hardware.microsoft-surface;
     if kernelVersion == "longterm" then
       "sha256-Pv7O8D8ma+MPLhYP3HSGQki+Yczp8b7d63qMb6l4+mY="
@@ -77,9 +77,6 @@ in {
       kernelParams = mkDefault [ "mem_sleep_default=deep" ];
     };
 
-    # NOTE: Check the README before enabling TLP:
-    services.tlp.enable = mkDefault false;
-
     # Needed for wifi firmware, see https://github.com/NixOS/nixos-hardware/issues/364
     hardware = {
       enableRedistributableFirmware = mkDefault true;