Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading a dependency with slap add will have Pip complaining if the upgraded version is not compatible with the requirement listed in the project #55

Open
NiklasRosenstein opened this issue Apr 12, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@NiklasRosenstein
Copy link
Owner

Installing your project with Pip will register its requirements in the .dist-info (also when linking, where it might instead be in .egg-info, but it doesn't matter). When you then try to upgrade a dependency, for example with slap add my-dependency^0.4.0 --upgrade, and the current declaration of the dependency is incompatible, for example my-dependency = "^0.3.0", then Pip will install it but you will get a warning that it is incompatible with your own project's installation.

We could work around this by temporarily un-installing your project from the Python environment, and then installing it again. Doing that however might be very slow. If the project is linked with slap link or slap install --link, then it could be fast because we just uninstall and then re-link it.

Maybe we should have slap add do that if the project is linked, and then add a notice if the project is not linked but hard-installed that you should prefer to work with a linked install of your project.

@NiklasRosenstein NiklasRosenstein added the enhancement New feature or request label Apr 12, 2022
@NiklasRosenstein NiklasRosenstein self-assigned this Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant