Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support for question factor_type #298

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jdeva
Copy link

@jdeva jdeva commented May 7, 2021

Adds support to the question factor that Okta provides

Description

Adds support to question factor type in Okta. Helps to authorise users who only have question factor assigned.

Related Issue

Support for question factor type #297

Motivation and Context

This change was required to enable users logging into aws, when they had only factor_type question assigned to them.

How Has This Been Tested?

The change was made only to okta.py, and tested by connecting to a live aws env.

Screenshots (if appropriate):

Screenshot 2021-05-07 at 21 10 44

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant