Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filter webauthn by authenticatorName #292

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

eedgar
Copy link
Contributor

@eedgar eedgar commented Mar 27, 2021

Handle the case where multiple webauthn keys are registered and you want to default to one.
eg you may have a macbook fingerprint and a yubikey both registered in okta but prefer the yubikey on certain devices.

@JonGilmore
Copy link
Contributor

hey @Sector95! any chance we could get a review on this?
Thanks!

@pawelaugustyn
Copy link

Hi @bwynsm, is there a chance you take a look at this?

@eedgar
Copy link
Contributor Author

eedgar commented Mar 30, 2022

@pawelaugustyn @bwynsm I have rebased this pr unto the latest to fix the merge conflict. This is working for me when I have multiple authenticators on an account, I dont have to select from the list anymore.

@zelch
Copy link

zelch commented Oct 7, 2022

Hey @eedgar , does the current version of #366 solve your use case?

It tackles it entirely differently, but I am hopeful that it will be even nicer for your use case.

@eedgar
Copy link
Contributor Author

eedgar commented Dec 14, 2022

@zelch I will take a look.

@eedgar
Copy link
Contributor Author

eedgar commented Dec 14, 2022

@zelch With my limited testing I have been running into issues with the 366 patch. my urllib and requests libs needed to be updated/replaced and that wasnt caught as part of the requirements.txt it seems.

I kept throwing this error until I did that
File "/home/eedgar/git/tools/gimme-aws-creds/gimme_aws_creds/aws.py", line 41, in init
retries = Retry(total=5, backoff_factor=1,
TypeError: init() got an unexpected keyword argument 'allowed_methods'

I had one successful run, now I am seeing this error.
File "/home/eedgar/.local/lib/python3.8/site-packages/requests/cookies.py", line 413, in _find_no_duplicates
raise KeyError(f"name={name!r}, domain={domain!r}, path={path!r}")
KeyError: "name='DT', domain=None, path=None"

It seems 366 may not be totally reliable yet.

@eedgar
Copy link
Contributor Author

eedgar commented Dec 14, 2022

You need to be using urllib3 1.26+ to use allowed_methods. I recommend upgrading your Requests and urllib3 versions.
from a comment here. psf/requests#5946

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants