Skip to content

Commit 67c567f

Browse files
gtrop1gtrop1
authored
Default Swift version now correctly set to 4.2 (#56)
Addressed issue where Swift version was incorrectly set to 5.0 when it should have been 4.2.
1 parent 901867b commit 67c567f

File tree

7 files changed

+19
-15
lines changed

7 files changed

+19
-15
lines changed

‎CHANGELOG.md

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ All notable changes to this project will be documented in this file.
55

66
#### 5.x Releases
77

8-
- `5.2.x` Releases - [5.2.0](#520)
8+
- `5.2.x` Releases - [5.2.0](#520) | [5.2.1](#521)
99
- `5.1.x` Releases - [5.1.0](#510)
1010
- `5.0.x` Releases - [5.0.0](#500) | [5.0.1](#501) | [5.0.2](#502)
1111

@@ -43,6 +43,16 @@ All notable changes to this project will be documented in this file.
4343

4444
---
4545

46+
## [5.2.1](https://github.com/Nike-Inc/Willow/releases/tag/5.2.1)
47+
Released on 2019-05-02. All issues associated with this milestone can be found using this
48+
[filter](https://github.com/Nike-Inc/Willow/milestone/14?closed=1).
49+
50+
#### Fixed
51+
- Issue where Swift version was incorrectly set to 5.0 when it should have been 4.2.
52+
- Fixed by [Greg Tropino](https://github.com/gtrop1) in Pull Request [#55](https://github.com/Nike-Inc/Willow/pull/55).
53+
54+
---
55+
4656
## [5.2.0](https://github.com/Nike-Inc/Willow/releases/tag/5.2.0)
4757

4858
#### Updated

‎Example/Frameworks/Database.xcodeproj/project.pbxproj

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -355,7 +355,7 @@
355355
ONLY_ACTIVE_ARCH = YES;
356356
SDKROOT = iphoneos;
357357
SWIFT_OPTIMIZATION_LEVEL = "-Onone";
358-
SWIFT_VERSION = 5.0;
358+
SWIFT_VERSION = 4.2;
359359
TARGETED_DEVICE_FAMILY = "1,2";
360360
TVOS_DEPLOYMENT_TARGET = 9.0;
361361
VERSIONING_SYSTEM = "apple-generic";
@@ -412,7 +412,7 @@
412412
MTL_ENABLE_DEBUG_INFO = NO;
413413
SDKROOT = iphoneos;
414414
SWIFT_COMPILATION_MODE = wholemodule;
415-
SWIFT_VERSION = 5.0;
415+
SWIFT_VERSION = 4.2;
416416
TARGETED_DEVICE_FAMILY = "1,2";
417417
TVOS_DEPLOYMENT_TARGET = 9.0;
418418
VALIDATE_PRODUCT = YES;
@@ -438,7 +438,6 @@
438438
PRODUCT_BUNDLE_IDENTIFIER = com.nike.Database;
439439
PRODUCT_NAME = "$(TARGET_NAME)";
440440
SKIP_INSTALL = YES;
441-
SWIFT_VERSION = 5.0;
442441
};
443442
name = Debug;
444443
};
@@ -458,7 +457,6 @@
458457
PRODUCT_BUNDLE_IDENTIFIER = com.nike.Database;
459458
PRODUCT_NAME = "$(TARGET_NAME)";
460459
SKIP_INSTALL = YES;
461-
SWIFT_VERSION = 5.0;
462460
};
463461
name = Release;
464462
};

‎Example/Frameworks/WebServices.xcodeproj/project.pbxproj

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -438,7 +438,6 @@
438438
PRODUCT_BUNDLE_IDENTIFIER = com.nike.WebServices;
439439
PRODUCT_NAME = "$(TARGET_NAME)";
440440
SKIP_INSTALL = YES;
441-
SWIFT_VERSION = 5.0;
442441
};
443442
name = Debug;
444443
};
@@ -458,7 +457,6 @@
458457
PRODUCT_BUNDLE_IDENTIFIER = com.nike.WebServices;
459458
PRODUCT_NAME = "$(TARGET_NAME)";
460459
SKIP_INSTALL = YES;
461-
SWIFT_VERSION = 5.0;
462460
};
463461
name = Release;
464462
};

‎Example/iOS Example.xcodeproj/project.pbxproj

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -361,7 +361,7 @@
361361
PRODUCT_NAME = "";
362362
SDKROOT = iphoneos;
363363
SWIFT_OPTIMIZATION_LEVEL = "-Onone";
364-
SWIFT_VERSION = 5.0;
364+
SWIFT_VERSION = 4.2;
365365
TARGETED_DEVICE_FAMILY = "1,2";
366366
TVOS_DEPLOYMENT_TARGET = 9.0;
367367
WATCHOS_DEPLOYMENT_TARGET = 2.0;
@@ -414,7 +414,7 @@
414414
PRODUCT_NAME = "";
415415
SDKROOT = iphoneos;
416416
SWIFT_COMPILATION_MODE = wholemodule;
417-
SWIFT_VERSION = 5.0;
417+
SWIFT_VERSION = 4.2;
418418
TARGETED_DEVICE_FAMILY = "1,2";
419419
TVOS_DEPLOYMENT_TARGET = 9.0;
420420
VALIDATE_PRODUCT = YES;
@@ -438,7 +438,6 @@
438438
PRODUCT_NAME = "iOS Example";
439439
PROVISIONING_PROFILE = "";
440440
PROVISIONING_PROFILE_SPECIFIER = "";
441-
SWIFT_VERSION = 5.0;
442441
};
443442
name = Debug;
444443
};
@@ -456,7 +455,6 @@
456455
PRODUCT_BUNDLE_IDENTIFIER = "com.nike.$(PRODUCT_NAME:rfc1034identifier)";
457456
PRODUCT_NAME = "iOS Example";
458457
PROVISIONING_PROFILE_SPECIFIER = "";
459-
SWIFT_VERSION = 5.0;
460458
};
461459
name = Release;
462460
};

‎Source/Info.plist

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
<key>CFBundlePackageType</key>
1616
<string>FMWK</string>
1717
<key>CFBundleShortVersionString</key>
18-
<string>5.2.0</string>
18+
<string>5.2.1</string>
1919
<key>CFBundleSignature</key>
2020
<string>????</string>
2121
<key>CFBundleVersion</key>

‎Willow.podspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
Pod::Spec.new do |s|
22
s.name = "Willow"
3-
s.version = "5.2.0"
3+
s.version = "5.2.1"
44
s.license = "MIT"
55
s.summary = "A powerful, yet lightweight logging library written in Swift."
66
s.homepage = "https://github.com/Nike-Inc/Willow"

‎Willow.xcodeproj/project.pbxproj

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -913,7 +913,7 @@
913913
ONLY_ACTIVE_ARCH = YES;
914914
SDKROOT = iphoneos;
915915
SWIFT_OPTIMIZATION_LEVEL = "-Onone";
916-
SWIFT_VERSION = 5.0;
916+
SWIFT_VERSION = 4.2;
917917
TARGETED_DEVICE_FAMILY = "1,2";
918918
TVOS_DEPLOYMENT_TARGET = 9.0;
919919
VERSIONING_SYSTEM = "apple-generic";
@@ -970,7 +970,7 @@
970970
MTL_ENABLE_DEBUG_INFO = NO;
971971
SDKROOT = iphoneos;
972972
SWIFT_OPTIMIZATION_LEVEL = "-Owholemodule";
973-
SWIFT_VERSION = 5.0;
973+
SWIFT_VERSION = 4.2;
974974
TARGETED_DEVICE_FAMILY = "1,2";
975975
TVOS_DEPLOYMENT_TARGET = 9.0;
976976
VALIDATE_PRODUCT = YES;

0 commit comments

Comments
 (0)