-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug fixes + tiny improvements #769
Conversation
…t with the chosen extension.
Im not sure if #711 should be considered fixed. Right now it downloads in AV1 if and only if there is a format option that has av1 and the same extension chosen.
That is the av01 option is only available in the mp4 format and not the webm. So, the prefer av1 option only downloads av1 if the chosen format is mp4. I see that we have functionality to convert videos, maybe we should use that? I'm not sure how it works. Since the option is 'prefer av1' not and 'only download av1', this behavior would be acceptable I think. |
f3ec008 needs to be tested. I couldn't figure out what I'm missing to build for windows. Is it even possible from linux? Here is a video with multiple audio languages: https://www.youtube.com/watch?v=Pv0iVoSZzN8&pp=ygUIbXIgYmVhc3Q%3D @nlogozzo I hope tiny improvements like this would be ok here. We can merge this pr later when you have time to properly go through everything. |
No 😅 I have a KVM setup with Windows to compile and push the Windows apps... |
Everything looks good, I saw let's say for #711 for when the whole download engine gets rewritten in the C++ rewrite soon |
Fixes #746
Fixes #729