Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Types overload missing for Push.Permission.request() #243

Open
Jicmou opened this issue Feb 19, 2020 · 0 comments
Open

Types overload missing for Push.Permission.request() #243

Jicmou opened this issue Feb 19, 2020 · 0 comments
Labels
enhancement

Comments

@Jicmou
Copy link

Jicmou commented Feb 19, 2020

Push.Permission.request()can either be called with 2 callback functions as parameters, or with no parameter at all, and in that cases, returns a Promise.

index.d.ts should be updated to take the two call signatures into account.

I can make a PR to fix that.

Regards,
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add type overload for Push.Permission.request()
2 participants
@theLufenk @Jicmou