forked from yifanlu/KindleTool
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Possible defect for base62 conversion #17
Comments
You bungled the link, so I'm afraid I have no idea what you're talking about ;). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Greetings!
I noticed that method baseN referred a StackOverflow post, while a recent comment to it mentioned that for codes start with '0's, decode('042') == decode('0042') == decode('00042') — which can lead to very subtle and hard to debug problems.
I'm trying to learn the usefulness of such small updates on StackOverflow. Would this comment help improve your code? I understand that such defect might not happen in real life situation. In that case, do you think this comment can help prevent future bugs (for example, when the code were reused somewhere else)?
I'll really appreciate it if you could kindly give me some feedback or suggestions. Thank you very much for your time.
Have a nice day!
The text was updated successfully, but these errors were encountered: