Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove autodetection of dtype from HDF5IO #632

Open
4 of 7 tasks
ajtritt opened this issue Sep 27, 2018 · 0 comments
Open
4 of 7 tasks

remove autodetection of dtype from HDF5IO #632

ajtritt opened this issue Sep 27, 2018 · 0 comments
Assignees
Labels
help wanted: deep dive request for community contributions that will involve many parts of the code base priority: low alternative solution already working and/or relevant to only specific user(s)
Milestone

Comments

@ajtritt
Copy link
Member

ajtritt commented Sep 27, 2018

Problem/Use Case

HDF5IO has logic for automatically determining dtype. This leads to the risk of different dtype serialization for different backends. To avoid this, dtype should be detected in ObjectMapper and passed into FORMIO/HDF5IO through DatasetBuilder.

  • Add dtype detection to ObjectMapper
  • Establish keys that Builders accept and which FORMIO also understands. The keys currently located at HDF5IO.__dtypes will probably suffice, but they should be explicitly established as allowable keys in DatasetBuilder.
  • Remove HDF5IO.get_type

Checklist

  • Have you ensured the feature or change was not already reported ?
  • Have you included a brief and descriptive title?
  • Have you included a clear description of the problem you are trying to solve?
  • Have you included a minimal code snippet that reproduces the issue you are encountering?
@ajtritt ajtritt added the help wanted: deep dive request for community contributions that will involve many parts of the code base label Sep 27, 2018
@ajtritt ajtritt added this to the NWB 2.x milestone Sep 27, 2018
@stephprince stephprince added the priority: low alternative solution already working and/or relevant to only specific user(s) label Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted: deep dive request for community contributions that will involve many parts of the code base priority: low alternative solution already working and/or relevant to only specific user(s)
Projects
None yet
Development

No branches or pull requests

4 participants