You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This was done in order to handle breaking changes in spikeinterface and major refactoring in neuroconv.
NWB GUIDE is tightly coupled to the Neuroconv interface - pretty much every change to Neuroconv, down to modifying the docstring of SpikeGLXRecordingInterface.__init__ impacts NWB GUIDE (the docstring of each argument is extracted and displayed in the NWB GUIDE source data entry page)
As a result, we need to monitor all changes in NeuroConv and evaluate their impact on NWB GUIDE function and UI.
For example, this change: catalystneuro/neuroconv#1155 results in the SpikeGLX Recording source data input to show both a File Path and a Folder Path input, when previously it showed a single required File Path input:
Before:
After:
It would be helpful to update NWB GUIDE regularly to handle changes in NeuroConv. Otherwise, it could be an overwhelming migration every 6-12 months.
Proposal: Create a workflow that checks to see if neuroconv has released a new version compared to the one pinned in the environment files, and if so, creates an issue ticket about it.
Steps to Reproduce
Remove NeuroConv pin from environment file, create clean environment, and run NWB GUIDE from source
Operating System
Mac
GUIDE Version
main
Code of Conduct
Yes
Did you confirm this issue was not already reported?
Yes
The text was updated successfully, but these errors were encountered:
Describe the issue
Currently, NWB GUIDE pins NeuroConv to a commit from August: https://github.com/catalystneuro/neuroconv/tree/fa636458aa5c321f1c2c08f6e682b4a52d5a83f3
This was done in order to handle breaking changes in spikeinterface and major refactoring in neuroconv.
NWB GUIDE is tightly coupled to the Neuroconv interface - pretty much every change to Neuroconv, down to modifying the docstring of
SpikeGLXRecordingInterface.__init__
impacts NWB GUIDE (the docstring of each argument is extracted and displayed in the NWB GUIDE source data entry page)As a result, we need to monitor all changes in NeuroConv and evaluate their impact on NWB GUIDE function and UI.
For example, this change: catalystneuro/neuroconv#1155 results in the SpikeGLX Recording source data input to show both a File Path and a Folder Path input, when previously it showed a single required File Path input:
Before:
![Image](https://private-user-images.githubusercontent.com/310197/408821141-057c0562-4be1-4258-8b05-b9a8a081a657.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg4OTY5NTksIm5iZiI6MTczODg5NjY1OSwicGF0aCI6Ii8zMTAxOTcvNDA4ODIxMTQxLTA1N2MwNTYyLTRiZTEtNDI1OC04YjA1LWI5YThhMDgxYTY1Ny5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjA3JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIwN1QwMjUwNTlaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0wOThhMjQyNDkxMTI3ZGNlYWU3YjQxMGU1NGE0ZjU3ZjUwN2JjOGQ2N2FlYjU2NDExOWY0NjEyZTY0ZDkyZjY4JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.VfQTpI15lP3vp7m2cg_8LRZyx2mg-cWCnwfFfpdTMto)
After:
![Image](https://private-user-images.githubusercontent.com/310197/408819403-45bd8e7e-94a9-4352-ba2f-44a117089dab.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg4OTY5NTksIm5iZiI6MTczODg5NjY1OSwicGF0aCI6Ii8zMTAxOTcvNDA4ODE5NDAzLTQ1YmQ4ZTdlLTk0YTktNDM1Mi1iYTJmLTQ0YTExNzA4OWRhYi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjA3JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIwN1QwMjUwNTlaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1hY2YxOGVlNjliMGNmOGE5ODg2OTc3YmFiZDQwNDU1NGM4NWQ5Yjg2NzYxZWY5Nzg2M2Q2ODk5OGRjNzlkMDdmJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.MDS7WybQkKn1WC0u2WmJlBrrmNLep8I6RNJMg1t7-lY)
It would be helpful to update NWB GUIDE regularly to handle changes in NeuroConv. Otherwise, it could be an overwhelming migration every 6-12 months.
Proposal: Create a workflow that checks to see if neuroconv has released a new version compared to the one pinned in the environment files, and if so, creates an issue ticket about it.
Steps to Reproduce
Remove NeuroConv pin from environment file, create clean environment, and run NWB GUIDE from source
Operating System
Mac
GUIDE Version
main
Code of Conduct
Yes
Did you confirm this issue was not already reported?
Yes
The text was updated successfully, but these errors were encountered: