Skip to content

Commit

Permalink
Remove support for Goerli (#372)
Browse files Browse the repository at this point in the history
* Removed Goerli from NetworkSupported and adjusted networks test

* Removed Goerli from templates/envs

* Removed Goerli from templates/envs

* Mentioned Goerli support removal in the changelog, goerli.mdx, and README

* Fixed TestSupportMEVBoost

* Removed Georli from TestGenerativeEnvFile

* Adjusted Test case 6 in TestCheckVariable

* Removed Georli from networks list for TestSupportedNetworks

* Removed Goerli from cli.go

* Adjusted test cli_test.go "consensus node" network into NetworkMainnet

* Replaced Goerli network from test cases in generate_test.go with valid networks

* Removed Goerli from GenerateCmd()

* Replaced Goerli in test cases with Mainnet

* Removed Goerli from KeysCmd()

* Removed Goerli from FullNodeSubCmd()

* Removed NetworkGoerli

* Fixed index_out_of_range error in Holesky related test cases in "Select network"

* Adjusted error in TestCli regarding "consensus node" test case

* Update cli/sub_gen.go

* docs: Update cli.mdx

* docs: Update clients.mdx

* docs: Update generate.mdx

* docs: Update keys.mdx

* docs: Update networks.mdx

* docs: Replace Goerli with Sepolia in run-validator-mev[network].md

* docs: Remove Goerli from documentations

* feat: remove Goerli from ImportKeys and associated tests

* docs: remove Goerli from docs
  • Loading branch information
khalifaa55 authored May 20, 2024
1 parent 4d41a7d commit 398245d
Show file tree
Hide file tree
Showing 43 changed files with 75 additions and 337 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

- Update client images to Dencun-ready versions.
-

### Removed
- Removed support for Goerli.

## [v1.3.1] - 2024-02-14

### Fixed
Expand Down
18 changes: 4 additions & 14 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ Sedge is a one-click node setup tool for PoS network/chain validators and nodes
- [Supported networks and clients](#supported-networks-and-clients)
- [Mainnet](#mainnet)
- [Sepolia](#sepolia)
- [Goerli](#goerli)
- [Holesky](#holesky)
- [Gnosis](#gnosis)
- [Chiado (Gnosis testnet)](#chiado-gnosis-testnet)
Expand Down Expand Up @@ -148,15 +147,6 @@ Users acknowledge that no warranty is being made of a successful installation. S
| Erigon | Prysm | Prysm |
| Besu | Teku | Teku |

### Goerli

| Execution | Consensus | Validator |
| ---------- | ---------- | ---------- |
| Geth | Lighthouse | Lighthouse |
| Nethermind | Lodestar | Lodestar |
| Erigon | Prysm | Prysm |
| Besu | Teku | Teku |

### Holesky

| Execution | Consensus | Validator |
Expand Down Expand Up @@ -186,10 +176,10 @@ Users acknowledge that no warranty is being made of a successful installation. S

| Client | Mev-Boost | Networks |
| ---------- | --------- |--------------------------|
| Lighthouse | yes | Mainnet, Goerli, Sepolia |
| Lodestar | yes | Mainnet, Goerli, Sepolia |
| Prysm | yes | Mainnet, Goerli, Sepolia |
| Teku | yes | Mainnet, Goerli, Sepolia |
| Lighthouse | yes | Mainnet, Sepolia |
| Lodestar | yes | Mainnet, Sepolia |
| Prysm | yes | Mainnet, Sepolia |
| Teku | yes | Mainnet, Sepolia |

## Supported Linux flavours for dependency installation

Expand Down
2 changes: 1 addition & 1 deletion cli/actions/importKeys.go
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,7 @@ func setupLodestarValidatorImport(dockerClient client.APIClient, serviceManager
// CMD
var preset string
switch options.Network {
case "mainnet", "goerli", "sepolia", "holesky":
case "mainnet", "sepolia", "holesky":
preset = "mainnet"
case "gnosis", "chiado":
preset = "gnosis"
Expand Down
4 changes: 2 additions & 2 deletions cli/actions/importKeys_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ func TestImportKeys_CustomOptions(t *testing.T) {
customImage bool
}{}
for _, validatorClient := range []string{"prysm", "lodestar"} {
for _, network := range []string{"sepolia", "goerli", "mainnet"} {
for _, network := range []string{"sepolia", "mainnet"} {
tests = append(tests, struct {
client string
network string
Expand All @@ -183,7 +183,7 @@ func TestImportKeys_CustomOptions(t *testing.T) {
}
}
for _, validatorClient := range []string{"lighthouse", "teku"} {
for _, network := range []string{"sepolia", "goerli", "mainnet"} {
for _, network := range []string{"sepolia", "mainnet"} {
tests = append(tests, struct {
client string
network string
Expand Down
3 changes: 1 addition & 2 deletions cli/cli.go
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ import (

const (
NetworkMainnet = "mainnet"
NetworkGoerli = "goerli"
NetworkSepolia = "sepolia"
NetworkGnosis = "gnosis"
NetworkChiado = "chiado"
Expand Down Expand Up @@ -616,7 +615,7 @@ func runPromptActions(p ui.Prompter, o *CliCmdOptions, actions ...promptAction)
}

func selectNetwork(p ui.Prompter, o *CliCmdOptions) error {
options := []string{NetworkMainnet, NetworkGoerli, NetworkSepolia, NetworkGnosis, NetworkChiado, NetworkHolesky}
options := []string{NetworkMainnet, NetworkSepolia, NetworkGnosis, NetworkChiado, NetworkHolesky}
index, err := p.Select("Select network", "", options)
if err != nil {
return err
Expand Down
18 changes: 9 additions & 9 deletions cli/cli_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ func TestCli(t *testing.T) {
}
sedgeActions.EXPECT().GetCommandRunner().Return(&test.SimpleCMDRunner{})
gomock.InOrder(
prompter.EXPECT().Select("Select network", "", []string{NetworkMainnet, NetworkGoerli, NetworkSepolia, NetworkGnosis, NetworkChiado, NetworkHolesky}).Return(0, nil),
prompter.EXPECT().Select("Select network", "", []string{NetworkMainnet, NetworkSepolia, NetworkGnosis, NetworkChiado, NetworkHolesky}).Return(0, nil),
prompter.EXPECT().Select("Select node type", "", []string{NodeTypeFullNode, NodeTypeExecution, NodeTypeConsensus, NodeTypeValidator}).Return(0, nil),
prompter.EXPECT().Input("Generation path", configs.DefaultAbsSedgeDataPath, false, nil).Return(generationPath, nil),
prompter.EXPECT().Input("Container tag, sedge will add to each container and the network, a suffix with the tag", "", false, nil).Return("tag", nil),
Expand Down Expand Up @@ -164,7 +164,7 @@ func TestCli(t *testing.T) {
JWTSecretPath: filepath.Join(generationPath, "jwtsecret"),
}
gomock.InOrder(
prompter.EXPECT().Select("Select network", "", []string{NetworkMainnet, NetworkGoerli, NetworkSepolia, NetworkGnosis, NetworkChiado, NetworkHolesky}).Return(0, nil),
prompter.EXPECT().Select("Select network", "", []string{NetworkMainnet, NetworkSepolia, NetworkGnosis, NetworkChiado, NetworkHolesky}).Return(0, nil),
prompter.EXPECT().Select("Select node type", "", []string{NodeTypeFullNode, NodeTypeExecution, NodeTypeConsensus, NodeTypeValidator}).Return(0, nil),
prompter.EXPECT().Input("Generation path", configs.DefaultAbsSedgeDataPath, false, nil).Return(generationPath, nil),
prompter.EXPECT().Input("Container tag, sedge will add to each container and the network, a suffix with the tag", "", false, nil).Return("tag", nil),
Expand Down Expand Up @@ -207,7 +207,7 @@ func TestCli(t *testing.T) {
JWTSecretPath: filepath.Join(generationPath, "jwtsecret"),
}
gomock.InOrder(
prompter.EXPECT().Select("Select network", "", []string{NetworkMainnet, NetworkGoerli, NetworkSepolia, NetworkGnosis, NetworkChiado, NetworkHolesky}).Return(5, nil),
prompter.EXPECT().Select("Select network", "", []string{NetworkMainnet, NetworkSepolia, NetworkGnosis, NetworkChiado, NetworkHolesky}).Return(4, nil),
prompter.EXPECT().Select("Select node type", "", []string{NodeTypeFullNode, NodeTypeExecution, NodeTypeConsensus, NodeTypeValidator}).Return(0, nil),
prompter.EXPECT().Input("Generation path", configs.DefaultAbsSedgeDataPath, false, nil).Return(generationPath, nil),
prompter.EXPECT().Input("Container tag, sedge will add to each container and the network, a suffix with the tag", "", false, nil).Return("tag", nil),
Expand Down Expand Up @@ -243,7 +243,7 @@ func TestCli(t *testing.T) {
}

gomock.InOrder(
prompter.EXPECT().Select("Select network", "", []string{NetworkMainnet, NetworkGoerli, NetworkSepolia, NetworkGnosis, NetworkChiado, NetworkHolesky}).Return(0, nil),
prompter.EXPECT().Select("Select network", "", []string{NetworkMainnet, NetworkSepolia, NetworkGnosis, NetworkChiado, NetworkHolesky}).Return(0, nil),
prompter.EXPECT().Select("Select node type", "", []string{NodeTypeFullNode, NodeTypeExecution, NodeTypeConsensus, NodeTypeValidator}).Return(1, nil),
prompter.EXPECT().Input("Generation path", configs.DefaultAbsSedgeDataPath, false, nil).Return(generationPath, nil),
prompter.EXPECT().Input("Container tag, sedge will add to each container and the network, a suffix with the tag", "", false, nil).Return("tag", nil),
Expand Down Expand Up @@ -286,7 +286,7 @@ func TestCli(t *testing.T) {
}

gomock.InOrder(
prompter.EXPECT().Select("Select network", "", []string{NetworkMainnet, NetworkGoerli, NetworkSepolia, NetworkGnosis, NetworkChiado, NetworkHolesky}).Return(5, nil),
prompter.EXPECT().Select("Select network", "", []string{NetworkMainnet, NetworkSepolia, NetworkGnosis, NetworkChiado, NetworkHolesky}).Return(4, nil),
prompter.EXPECT().Select("Select node type", "", []string{NodeTypeFullNode, NodeTypeExecution, NodeTypeConsensus, NodeTypeValidator}).Return(1, nil),
prompter.EXPECT().Input("Generation path", configs.DefaultAbsSedgeDataPath, false, nil).Return(generationPath, nil),
prompter.EXPECT().Input("Container tag, sedge will add to each container and the network, a suffix with the tag", "", false, nil).Return("tag", nil),
Expand Down Expand Up @@ -323,7 +323,7 @@ func TestCli(t *testing.T) {
Type: "consensus",
Image: configs.ClientImages.Consensus.Lodestar.String(),
},
Network: NetworkGoerli,
Network: NetworkMainnet,
CheckpointSyncUrl: "http://checkpoint.sync",
FeeRecipient: "0x2d07a21ebadde0c13e8b91022a7e5732eb6bf5d5",
MapAllPorts: true,
Expand All @@ -335,7 +335,7 @@ func TestCli(t *testing.T) {
}

gomock.InOrder(
prompter.EXPECT().Select("Select network", "", []string{NetworkMainnet, NetworkGoerli, NetworkSepolia, NetworkGnosis, NetworkChiado, NetworkHolesky}).Return(1, nil),
prompter.EXPECT().Select("Select network", "", []string{NetworkMainnet, NetworkSepolia, NetworkGnosis, NetworkChiado, NetworkHolesky}).Return(0, nil),
prompter.EXPECT().Select("Select node type", "", []string{NodeTypeFullNode, NodeTypeExecution, NodeTypeConsensus, NodeTypeValidator}).Return(2, nil),
prompter.EXPECT().Input("Generation path", configs.DefaultAbsSedgeDataPath, false, nil).Return(generationPath, nil),
prompter.EXPECT().Input("Container tag, sedge will add to each container and the network, a suffix with the tag", "", false, nil).Return("tag", nil),
Expand Down Expand Up @@ -377,7 +377,7 @@ func TestCli(t *testing.T) {
}

gomock.InOrder(
prompter.EXPECT().Select("Select network", "", []string{NetworkMainnet, NetworkGoerli, NetworkSepolia, NetworkGnosis, NetworkChiado, NetworkHolesky}).Return(5, nil),
prompter.EXPECT().Select("Select network", "", []string{NetworkMainnet, NetworkSepolia, NetworkGnosis, NetworkChiado, NetworkHolesky}).Return(4, nil),
prompter.EXPECT().Select("Select node type", "", []string{NodeTypeFullNode, NodeTypeExecution, NodeTypeConsensus, NodeTypeValidator}).Return(2, nil),
prompter.EXPECT().Input("Generation path", configs.DefaultAbsSedgeDataPath, false, nil).Return(generationPath, nil),
prompter.EXPECT().Input("Container tag, sedge will add to each container and the network, a suffix with the tag", "", false, nil).Return("tag", nil),
Expand Down Expand Up @@ -419,7 +419,7 @@ func TestCli(t *testing.T) {
}

gomock.InOrder(
prompter.EXPECT().Select("Select network", "", []string{NetworkMainnet, NetworkGoerli, NetworkSepolia, NetworkGnosis, NetworkChiado, NetworkHolesky}).Return(0, nil),
prompter.EXPECT().Select("Select network", "", []string{NetworkMainnet, NetworkSepolia, NetworkGnosis, NetworkChiado, NetworkHolesky}).Return(0, nil),
prompter.EXPECT().Select("Select node type", "", []string{NodeTypeFullNode, NodeTypeExecution, NodeTypeConsensus, NodeTypeValidator}).Return(3, nil),
prompter.EXPECT().Input("Generation path", configs.DefaultAbsSedgeDataPath, false, nil).Return(generationPath, nil),
prompter.EXPECT().Input("Container tag, sedge will add to each container and the network, a suffix with the tag", "", false, nil).Return("tag", nil),
Expand Down
2 changes: 1 addition & 1 deletion cli/generate.go
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ You can generate:
cmd.AddCommand(MevBoostSubCmd(sedgeAction))

cmd.PersistentFlags().StringVarP(&generationPath, "path", "p", configs.DefaultAbsSedgeDataPath, "generation path for sedge data. Default is sedge-data")
cmd.PersistentFlags().StringVarP(&network, "network", "n", "mainnet", "Target network. e.g. mainnet, goerli, sepolia, holesky, gnosis, chiado, etc.")
cmd.PersistentFlags().StringVarP(&network, "network", "n", "mainnet", "Target network. e.g. mainnet,sepolia, holesky, gnosis, chiado, etc.")
cmd.PersistentFlags().StringVar(&logging, "logging", "json", fmt.Sprintf("Docker logging driver used by all the services. Set 'none' to use the default docker logging driver. Possible values: %v", configs.ValidLoggingFlags()))
cmd.PersistentFlags().StringVar(&containerTag, "container-tag", "", "Container tag to use. If defined, sedge will add to each container and the network, a suffix with the tag. e.g. sedge-validator-client -> sedge-validator-client-<tag>.")
return cmd
Expand Down
8 changes: 4 additions & 4 deletions cli/generate_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1102,7 +1102,7 @@ func TestGenerateCmd(t *testing.T) {
consensusApiUrl: "http://localhost:4000",
},
globalFlags{
network: "goerli",
network: "holesky",
},
nil,
},
Expand All @@ -1117,7 +1117,7 @@ func TestGenerateCmd(t *testing.T) {
consensusApiUrl: "localhost/4000",
},
globalFlags{
network: "goerli",
network: "gnosis",
},
fmt.Errorf(configs.InvalidUrlFlagError, "consensus api", "localhost/4000"),
},
Expand Down Expand Up @@ -1147,7 +1147,7 @@ func TestGenerateCmd(t *testing.T) {
consensusApiUrl: "localhost:4000",
},
globalFlags{
network: "goerli",
network: "gnosis",
},
fmt.Errorf(configs.InvalidUrlFlagError, "consensus api", "localhost:4000"),
},
Expand Down Expand Up @@ -1223,7 +1223,7 @@ func TestGenerateCmd(t *testing.T) {
graffiti: "sedge-graffiti-sedge",
},
globalFlags{
network: "goerli",
network: "holesky",
},
fmt.Errorf(configs.ErrGraffitiLength, "sedge-graffiti-sedge", 20),
},
Expand Down
10 changes: 5 additions & 5 deletions cli/importKeys_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ func TestImportKeys_NumberOfArguments(t *testing.T) {
},
{
name: "with flags",
args: []string{"--network", "goerli"},
args: []string{"--network", "mainnet"},
},
}
for _, tt := range tests {
Expand Down Expand Up @@ -85,7 +85,7 @@ func TestImportKeys_ArgsAndFlags(t *testing.T) {
name: "with flags",
args: []string{
"prysm",
"--network", "goerli",
"--network", "mainnet",
"--from", "/tmp/keystore",
"--path", "/tmp/sedge",
"--start-validator",
Expand All @@ -96,7 +96,7 @@ func TestImportKeys_ArgsAndFlags(t *testing.T) {
},
expectedOptions: actions.ImportValidatorKeysOptions{
ValidatorClient: "prysm",
Network: "goerli",
Network: "mainnet",
StartValidator: true,
GenerationPath: "/tmp/sedge",
From: "/tmp/keystore",
Expand All @@ -106,7 +106,7 @@ func TestImportKeys_ArgsAndFlags(t *testing.T) {
name: "with shorthand flags",
args: []string{
"teku",
"-n", "goerli",
"-n", "mainnet",
"--from", "/tmp/keystore",
"-p", "/tmp/sedge",
"--stop-validator",
Expand All @@ -117,7 +117,7 @@ func TestImportKeys_ArgsAndFlags(t *testing.T) {
},
expectedOptions: actions.ImportValidatorKeysOptions{
ValidatorClient: "teku",
Network: "goerli",
Network: "mainnet",
From: "/tmp/keystore",
GenerationPath: "/tmp/sedge",
StopValidator: true,
Expand Down
2 changes: 1 addition & 1 deletion cli/keys.go
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ func KeysCmd(cmdRunner commands.CommandRunner, p ui.Prompter) *cobra.Command {
},
}
// Flag binds
cmd.Flags().StringVarP(&flags.network, "network", "n", "mainnet", "Target network. e.g. mainnet, goerli, sepolia, holesky, gnosis, chiado etc.")
cmd.Flags().StringVarP(&flags.network, "network", "n", "mainnet", "Target network. e.g. mainnet,sepolia, holesky, gnosis, chiado etc.")
cmd.Flags().StringVarP(&flags.path, "path", "p", configs.DefaultAbsSedgeDataPath, "Absolute path to keystore folder. e.g. /home/user/keystore")
cmd.Flags().StringVar(&flags.eth1WithdrawalAddress, "eth1-withdrawal-address", "", "If this field is set and valid, the given Eth1 address will be used to create the withdrawal credentials. Otherwise, it will generate withdrawal credentials with the mnemonic-derived withdrawal public key in EIP-2334 format.")
cmd.Flags().StringVar(&flags.mnemonicPath, "mnemonic-path", "", "Path to file with a existing mnemonic to use.")
Expand Down
4 changes: 2 additions & 2 deletions cli/sub_gen.go
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ func FullNodeSubCmd(sedgeAction actions.SedgeActions) *cobra.Command {
It will not generate a validator configuration if the --no-validator flag is set to true.
On mainnet, sepolia and goerli, mev-boost will be activated by default unless you run it with --no-mev-boost flag.
On mainnet and sepolia mev-boost will be activated by default unless you run it with --no-mev-boost flag.
If you don't provide a execution, consensus or validator client, it will be chosen randomly. If one of the consensus or validator is provided, but the other one is omitted, then the same pair of clients will be used for both consensus and validator.
Expand Down Expand Up @@ -273,7 +273,7 @@ func MevBoostSubCmd(sedgeAction actions.SedgeActions) *cobra.Command {
// Bind flags
cmd.Flags().StringSliceVar(&flags.relayURLs, "relay-urls", []string{}, "List of comma separated relay URLs used to connect to mev relay. Example: 'sedge generate mev-boost --relay-urls=https://0xac6e77dfe25ecd6110b8e780608cce0dab71fdd5ebea22a16c0205200f2f8e2e3ad3b71d3499c54ad14d6c21b41a37ae@boost-relay.flashbots.net,https://0xa1559ace749633b997cb3fdacffb890aeebdb0f5a3b6aaa7eeeaf1a38af0a8fe88b9e4b1f61f236d2e64d95733327a62@relay.ultrasound.money'")
cmd.Flags().StringVarP(&flags.mevImage, "mev-boost-image", "m", "", "Custom docker image to use for Mev Boost. Example: 'sedge generate mev-boost --mev-boost-image flashbots/mev-boost:latest-portable'")
cmd.Flags().StringVarP(&network, "network", "n", "mainnet", "Target network. e.g. mainnet, goerli, sepolia etc.")
cmd.Flags().StringVarP(&network, "network", "n", "mainnet", "Target network. e.g. mainnet, sepolia etc.")
cmd.Flags().SortFlags = false
return cmd
}
14 changes: 0 additions & 14 deletions configs/init.go
Original file line number Diff line number Diff line change
Expand Up @@ -33,20 +33,6 @@ var networksConfigs map[string]NetworkConfig = map[string]NetworkConfig{
"https://0xa1559ace749633b997cb3fdacffb890aeebdb0f5a3b6aaa7eeeaf1a38af0a8fe88b9e4b1f61f236d2e64d95733327a62@relay.ultrasound.money",
},
},
NetworkGoerli: {
Name: NetworkGoerli,
NetworkService: "merge",
GenesisForkVersion: "0x00001020",
SupportsMEVBoost: true,
CheckpointSyncURL: "https://goerli.checkpoint-sync.ethpandaops.io",
RelayURLs: []string{
"https://0xafa4c6985aa049fb79dd37010438cfebeb0f2bd42b115b89dd678dab0670c1de38da0c4e9138c9290a398ecd9a0b3110@builder-relay-goerli.flashbots.net",
"https://0x821f2a65afb70e7f2e820a925a9b4c80a159620582c1766b1b09729fec178b11ea22abb3a51f07b288be815a1a2ff516@bloxroute.max-profit.builder.goerli.blxrbdn.com",
"https://0x8f7b17a74569b7a57e9bdafd2e159380759f5dc3ccbd4bf600414147e8c4e1dc6ebada83c0139ac15850eb6c975e82d0@builder-relay-goerli.blocknative.com",
"https://0xb1d229d9c21298a87846c7022ebeef277dfc321fe674fa45312e20b5b6c400bfde9383f801848d7837ed5fc449083a12@relay-goerli.edennetwork.io",
"https://0xb1559beef7b5ba3127485bbbb090362d9f497ba64e177ee2c8e7db74746306efad687f2cf8574e38d70067d40ef136dc@relay-stag.ultrasound.money",
},
},
NetworkSepolia: {
Name: NetworkSepolia,
NetworkService: "merge",
Expand Down
6 changes: 2 additions & 4 deletions configs/networks.go
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ import (
const (
// Network names
NetworkMainnet = "mainnet"
NetworkGoerli = "goerli"
NetworkSepolia = "sepolia"
NetworkGnosis = "gnosis"
NetworkChiado = "chiado"
Expand All @@ -36,7 +35,7 @@ var ErrInvalidNetwork = errors.New("invalid network")

func NetworkCheck(value string) error {
switch value {
case NetworkMainnet, NetworkGoerli, NetworkSepolia, NetworkGnosis, NetworkChiado, NetworkHolesky, NetworkCustom:
case NetworkMainnet, NetworkSepolia, NetworkGnosis, NetworkChiado, NetworkHolesky, NetworkCustom:
return nil
default:
return fmt.Errorf("%w: %s", ErrInvalidNetwork, value)
Expand All @@ -47,7 +46,6 @@ func NetworkSupported() []string {
// notest
return []string{
NetworkMainnet,
NetworkGoerli,
NetworkSepolia,
NetworkGnosis,
NetworkChiado,
Expand All @@ -58,7 +56,7 @@ func NetworkSupported() []string {

func NetworkEpochTime(network string) time.Duration {
switch network {
case NetworkMainnet, NetworkGoerli, NetworkSepolia:
case NetworkMainnet, NetworkSepolia:
return 7 * time.Minute
case NetworkGnosis, NetworkChiado:
return 2 * time.Minute
Expand Down
8 changes: 4 additions & 4 deletions configs/networks_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@ func TestNetworkCheck(t *testing.T) {
wantErr: false,
},
{
name: "Valid network, goerli",
name: "Invalid network, goerli",
network: "goerli",
wantErr: false,
wantErr: true,
},
{
name: "Valid network, sepolia",
Expand Down Expand Up @@ -65,9 +65,9 @@ func TestSupportMEVBoost(t *testing.T) {
want: true,
},
{
name: "Valid network, goerli",
name: "Invalid network, goerli",
network: "goerli",
want: true,
want: false,
},
{
name: "Valid network, sepolia",
Expand Down
Loading

0 comments on commit 398245d

Please sign in to comment.