Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NethVoice: ICE ignore list is not in the correct format as a parameter for Janus #7023

Closed
andrea-marchionni opened this issue Sep 16, 2024 · 3 comments
Labels
nethvoice Bug or features releted to the NethVoice project verified All test cases were verified successfully
Milestone

Comments

@andrea-marchionni
Copy link

andrea-marchionni commented Sep 16, 2024

Janus is launched with a set of parameters from the unit including the list of interfaces to ignore in ICE negotiation.
This.

The variable, containing the list, is not expanded:

[nethvoice5@ns8n4 state]$ podman exec -it janus bash

root@ns8n4:/# cat /proc/1/cmdline 
/usr/local/bin/janus--configs-folder=/usr/local/etc/janus--interface=lo--ice-ignore-list=${ICEIGNORE:=vmnet,tap,tun,virb,vb-}--stun-server=stun1.l.google.com:19302--rtp-port-range=21002-22001--cert-pem=/etc/certificates/NethServer.pem--cert-key=/etc/certificates/NethServer.key--debug-level=5 

This means that Janus tries to negotiate the ICE in all interfaces and if it finds one that does not have access to the internet for example, failing, it waits for the timeout to arrive to move on to the next one.

However, this causes the call to be dropped on the Asterisk side.

It should be like this:

root@ns8:/# cat /proc/1/cmdline 
/usr/local/bin/janus--configs-folder=/usr/local/etc/janus--interface=lo--ice-ignore-list=wg0,ens33,vmnet,tap,tun,virb,vb---stun-server=stun1.l.google.com:19302--rtp-port-range=21002-22001--cert-pem=/etc/certificates/NethServer.pem--cert-key=/etc/certificates/NethServer.key--debug-level=5
@Amygos
Copy link
Member

Amygos commented Oct 1, 2024

Testing release: 1.0.2-testing.3

@Amygos Amygos added the testing Packages are available from testing repositories label Oct 1, 2024
@Amygos
Copy link
Member

Amygos commented Oct 1, 2024

Test Case: Verify Correct Expansion of ICE Ignore List in Janus

Description: Ensure Janus properly expands the ICEIGNORE variable during launch, preventing ICE negotiation on specified interfaces after installing the NethVoice module from the testing repository.

Pre-conditions:

  • The NethVoice module is installed from the testing repository.
  • Janus is configured with the ICEIGNORE variable set (e.g., wg0, ens33, vmnet, tap, tun, virb, vb-).

Steps to reproduce:

  1. Access the Janus container using Podman:
    podman exec -it janus bash
  2. Check the command line of the Janus process:
    cat /proc/1/cmdline
  3. Verify the --ice-ignore-list contains the expanded interfaces list.

Expected behavior:

  • The ICEIGNORE variable should expand correctly, and Janus should display the proper interfaces to ignore.

Post-conditions:

  • None.

@andrea-marchionni andrea-marchionni added verified All test cases were verified successfully and removed testing Packages are available from testing repositories labels Oct 3, 2024
@Amygos
Copy link
Member

Amygos commented Oct 3, 2024

Released 1.0.2

@Amygos Amygos closed this as completed Oct 3, 2024
@github-project-automation github-project-automation bot moved this from Verified to Done in NethVoice Oct 3, 2024
@Amygos Amygos removed the bug label Nov 7, 2024
@Amygos Amygos added this to the NethVoice 1.0 milestone Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
nethvoice Bug or features releted to the NethVoice project verified All test cases were verified successfully
Projects
Archived in project
Development

No branches or pull requests

2 participants