Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow uploading metaflow packages that include "dots" in the path #1788

Open
cburroughs opened this issue Mar 29, 2024 · 0 comments
Open

allow uploading metaflow packages that include "dots" in the path #1788

cburroughs opened this issue Mar 29, 2024 · 0 comments

Comments

@cburroughs
Copy link

Dots (.) are a common character to have in a unix path so I'm not sure how much justifying context is needed but:

We use a build system (Pants) that attempts to execute code in a sandboxed directory. This is broadly similar to Bazel/Buck/Please/etc. It would be a common idiom to have said sandbox along with logs and other build related files in something named along the lines $REPO/.buildtool. This doesn't work for Metaflow due to this exclusion code: https://github.com/Netflix/metaflow/blob/master/metaflow/package.py#L85C16-L85C30

I was unable to find a reason for the exclusion through git blame.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant