From d465c6be9504934fe612dfca4ff50c5561e05755 Mon Sep 17 00:00:00 2001
From: Nayanesh Gupte <nayanesh@hotstar.com>
Date: Tue, 19 Apr 2016 07:29:54 +0530
Subject: [PATCH] code improvement

---
 app/app.iml                                   | 10 ++++--
 .../adapter/IssuesListAdapter.java            |  3 +-
 .../fragment/GitCommentsListFragment.java     |  1 -
 .../fragment/GitIssuesListFragment.java       | 34 ++++++++-----------
 4 files changed, 23 insertions(+), 25 deletions(-)

diff --git a/app/app.iml b/app/app.iml
index e7d1ad8..5eef367 100644
--- a/app/app.iml
+++ b/app/app.iml
@@ -85,10 +85,16 @@
       <excludeFolder url="file://$MODULE_DIR$/build/intermediates/exploded-aar/com.android.support/recyclerview-v7/23.0.1/jars" />
       <excludeFolder url="file://$MODULE_DIR$/build/intermediates/exploded-aar/com.android.support/support-v4/23.0.1/jars" />
       <excludeFolder url="file://$MODULE_DIR$/build/intermediates/incremental" />
+      <excludeFolder url="file://$MODULE_DIR$/build/intermediates/incremental-classes" />
+      <excludeFolder url="file://$MODULE_DIR$/build/intermediates/incremental-runtime-classes" />
+      <excludeFolder url="file://$MODULE_DIR$/build/intermediates/incremental-verifier" />
+      <excludeFolder url="file://$MODULE_DIR$/build/intermediates/instant-run-support" />
       <excludeFolder url="file://$MODULE_DIR$/build/intermediates/jniLibs" />
       <excludeFolder url="file://$MODULE_DIR$/build/intermediates/manifests" />
       <excludeFolder url="file://$MODULE_DIR$/build/intermediates/pre-dexed" />
+      <excludeFolder url="file://$MODULE_DIR$/build/intermediates/reload-dex" />
       <excludeFolder url="file://$MODULE_DIR$/build/intermediates/res" />
+      <excludeFolder url="file://$MODULE_DIR$/build/intermediates/restart-dex" />
       <excludeFolder url="file://$MODULE_DIR$/build/intermediates/rs" />
       <excludeFolder url="file://$MODULE_DIR$/build/intermediates/symbols" />
       <excludeFolder url="file://$MODULE_DIR$/build/intermediates/transforms" />
@@ -97,11 +103,11 @@
     </content>
     <orderEntry type="jdk" jdkName="Android API 23 Platform" jdkType="Android SDK" />
     <orderEntry type="sourceFolder" forTests="false" />
+    <orderEntry type="library" exported="" name="recyclerview-v7-23.0.1" level="project" />
     <orderEntry type="library" exported="" name="gson-2.6.2" level="project" />
     <orderEntry type="library" exported="" name="cardview-v7-23.0.1" level="project" />
-    <orderEntry type="library" exported="" name="appcompat-v7-23.0.1" level="project" />
-    <orderEntry type="library" exported="" name="recyclerview-v7-23.0.1" level="project" />
     <orderEntry type="library" exported="" name="support-v4-23.0.1" level="project" />
+    <orderEntry type="library" exported="" name="appcompat-v7-23.0.1" level="project" />
     <orderEntry type="library" exported="" name="support-annotations-23.0.1" level="project" />
     <orderEntry type="module" module-name="volley" exported="" />
   </component>
diff --git a/app/src/main/java/com/twittercrashlytics/adapter/IssuesListAdapter.java b/app/src/main/java/com/twittercrashlytics/adapter/IssuesListAdapter.java
index e8e4204..0e3541d 100644
--- a/app/src/main/java/com/twittercrashlytics/adapter/IssuesListAdapter.java
+++ b/app/src/main/java/com/twittercrashlytics/adapter/IssuesListAdapter.java
@@ -50,8 +50,7 @@ public void add(List<Issue> data) {
     @Override
     public IssuesViewHolder onCreateViewHolder(ViewGroup parent, int viewType) {
         View view = inflater.inflate(R.layout.row_issues, parent, false);
-        IssuesViewHolder holder = new IssuesViewHolder(view);
-        return holder;
+        return new IssuesViewHolder(view);
     }
 
     @Override
diff --git a/app/src/main/java/com/twittercrashlytics/fragment/GitCommentsListFragment.java b/app/src/main/java/com/twittercrashlytics/fragment/GitCommentsListFragment.java
index c9c5426..48feb1d 100644
--- a/app/src/main/java/com/twittercrashlytics/fragment/GitCommentsListFragment.java
+++ b/app/src/main/java/com/twittercrashlytics/fragment/GitCommentsListFragment.java
@@ -125,7 +125,6 @@ public void onDetach() {
     @Override
     public void onDataReceived(List<Comment> listIssues) {
 
-        progressBar.setVisibility(View.GONE);
 
         commentsListAdapter.add(listIssues);
         progressBar.setVisibility(View.GONE);
diff --git a/app/src/main/java/com/twittercrashlytics/fragment/GitIssuesListFragment.java b/app/src/main/java/com/twittercrashlytics/fragment/GitIssuesListFragment.java
index c945034..927a13b 100644
--- a/app/src/main/java/com/twittercrashlytics/fragment/GitIssuesListFragment.java
+++ b/app/src/main/java/com/twittercrashlytics/fragment/GitIssuesListFragment.java
@@ -30,7 +30,7 @@
 /**
  * Fragment holding list of issues.
  */
-public class GitIssuesListFragment extends Fragment implements IAppConstants, OnItemClickListener {
+public class GitIssuesListFragment extends Fragment implements IAppConstants, OnItemClickListener, Response.Listener<Issue[]> {
 
 
     private static final String TAG = GitIssuesListFragment.class.getSimpleName();
@@ -92,7 +92,7 @@ private void getIssuesList() {
             GsonRequest<Issue[]> myReq = new GsonRequest<Issue[]>(BASE_URL,
                     Issue[].class,
                     null,
-                    createMyReqSuccessListener(),
+                    this,
                     createMyReqErrorListener());
 
             TwitterCrashlyticsApplication.getInstance().addToRequestQueue(myReq, TAG);
@@ -107,24 +107,6 @@ private void getIssuesList() {
 
     }
 
-    private Response.Listener<Issue[]> createMyReqSuccessListener() {
-        return new Response.Listener<Issue[]>() {
-            @Override
-            public void onResponse(Issue[] response) {
-
-                List<Issue> listIssues = Arrays.asList(response);
-
-                Collections.sort(listIssues, new DateComparator());
-
-                issuesListAdapter.add(listIssues);
-
-
-                progressBar.setVisibility(View.GONE);
-
-            }
-
-        };
-    }
 
     private Response.ErrorListener createMyReqErrorListener() {
         return new Response.ErrorListener() {
@@ -161,4 +143,16 @@ public void onDetach() {
     }
 
 
+    @Override
+    public void onResponse(Issue[] response) {
+
+        List<Issue> listIssues = Arrays.asList(response);
+
+        Collections.sort(listIssues, new DateComparator());
+
+        issuesListAdapter.add(listIssues);
+
+
+        progressBar.setVisibility(View.GONE);
+    }
 }