Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ns clean doesnt respect package manager #5800

Open
3 tasks done
offizium-berndstorath opened this issue Apr 18, 2024 · 1 comment
Open
3 tasks done

ns clean doesnt respect package manager #5800

offizium-berndstorath opened this issue Apr 18, 2024 · 1 comment

Comments

@offizium-berndstorath
Copy link

offizium-berndstorath commented Apr 18, 2024

Issue Description

If I set pnpm as the ns package manager and run ns clean it tries to remove package-lock.json which obviously doesnt exist

Reproduction

  1. Use any ns project
  2. set pnpm as package manager
  3. run ns clean

Relevant log output (if applicable)

No response

Environment

echo 'y' | npx nativescript-envinfo Doesnt show pnpm version. So this makes no sense

Please accept these terms

@offizium-berndstorath offizium-berndstorath added the bug-pending-triage Reported bug, pending triage to confirm. label Apr 18, 2024
@rigor789
Copy link
Member

We will remove package-lock.json from ns clean by default in a future release. Users will still be able to configure additionalPathsToClean and add it back, or a different package-manager's lockfile.

Right now this is known/expected behavior, and the file is skipped if not found.

@rigor789 rigor789 removed the bug-pending-triage Reported bug, pending triage to confirm. label Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants