Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace check for emulator package with check for sdkmanager #5756

Open
2 tasks done
systemc12ashe opened this issue Aug 25, 2023 · 1 comment
Open
2 tasks done

Replace check for emulator package with check for sdkmanager #5756

systemc12ashe opened this issue Aug 25, 2023 · 1 comment
Labels

Comments

@systemc12ashe
Copy link

Is your feature request related to a problem? Please describe.

In our case, we only have the emulator package installed for tests and not for the build job. This causes an error “✖WARNING: The Android SDK is not installed or is not configured properly”. CI builds are often run inside containers, and it may not make sense to have an emulator because nested virtualization may not be supported. So now we are made to install the emulator inside a Docker image even though you don’t need an emulator to build an Android binary.

Describe the solution you'd like

It might be more effective to check for the sdkmanager in order to validate whether the Android SDK has been properly installed. The sdkmanager could have the ability to install the emulator if it is missing and required.

Describe alternatives you've considered

Our solution has been to create a workaround in which there is a file that mimics the emulator in order to avoid the error mentioned above.

Anything else?

I hope to contribute to this issue and am actively looking to solve it if approved.

Please accept these terms

@systemc12ashe systemc12ashe added the feature-pending-triage A new feature request pending triage to confirm validity. label Aug 25, 2023
@rigor789
Copy link
Member

You can pass the --force flag on CI to skip environment checks, but yes in general improvements to doctor and the checks is something we intend to ship - have a general rewrite in progress on a branch here: #5674

@rigor789 rigor789 added feature and removed feature-pending-triage A new feature request pending triage to confirm validity. labels Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants