Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ns clean - should remove yarn.lock if the package manager for the project is yarn #5732

Open
2 tasks done
shiv19 opened this issue Apr 12, 2023 · 1 comment
Open
2 tasks done
Labels
Milestone

Comments

@shiv19
Copy link
Member

shiv19 commented Apr 12, 2023

Is your feature request related to a problem? Please describe.

When you run ns clean on a project that uses yarn as the package manager, the CLI still tries to remove a package-lock.json instead of yarn.lock

Describe the solution you'd like

If the package manager of the project is yarn, then ns clean should attempt to remove yarn.lock if it exists.

Describe alternatives you've considered

As an alternative, the developer could be prompted if they wish to remove yarn.lock or package-lock.json.

Anything else?

No response

Please accept these terms

@shiv19 shiv19 added the feature-pending-triage A new feature request pending triage to confirm validity. label Apr 12, 2023
@NathanWalker NathanWalker added this to the 8.6 milestone Apr 12, 2023
@rigor789
Copy link
Member

For 8.6 we're likely going to remove the lockfiles from the default clean paths, and let users opt-in via their own configs... Which you can already do:

cli: {
  additionalPathsToClean: ['yarn.lock']
}

/cc @edusperoni

@rigor789 rigor789 added feature and removed feature-pending-triage A new feature request pending triage to confirm validity. labels Apr 13, 2023
@NathanWalker NathanWalker modified the milestones: 8.6, 9.0 Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants