pkp/pkp-lib#7191 Fix series creation error messages

asmecher · asmecher · commit 5a04dc8a0611 · 2022-12-13T23:18:21.000-08:00
diff --git a/controllers/grid/settings/series/form/SeriesForm.php b/controllers/grid/settings/series/form/SeriesForm.php
@@ -69,7 +69,7 @@ function ($path) use ($form, $pressId) {
         ));
     }
 
-    public function getSeries(): Series
+    public function getSeries(): ?Series
     {
         return $this->section;
     }
@@ -197,7 +197,7 @@ public function fetch($request, $template = null, $display = false)
 
         $templateMgr->assign([
             'allCategories' => $allCategories,
-            'selectedCategories' => $this->getData('categories')->values()->all(),
+            'selectedCategories' => $this->getData('categories')?->values()?->all() ?? [],
         ]);
 
         return parent::fetch($request, $template, $display);

Original file line number	Diff line number	Diff line change
`@@ -69,7 +69,7 @@ function ($path) use ($form, $pressId) {`
`69`	`69`	`));`
`70`	`70`	`}`
`71`	`71`
`72`		`- public function getSeries(): Series`
	`72`	`+ public function getSeries(): ?Series`
`73`	`73`	`{`
`74`	`74`	`return $this->section;`
`75`	`75`	`}`
`@@ -197,7 +197,7 @@ public function fetch($request, $template = null, $display = false)`
`197`	`197`
`198`	`198`	`$templateMgr->assign([`
`199`	`199`	`'allCategories' => $allCategories,`
`200`		`- 'selectedCategories' => $this->getData('categories')->values()->all(),`
	`200`	`+ 'selectedCategories' => $this->getData('categories')?->values()?->all() ?? [],`
`201`	`201`	`]);`
`202`	`202`
`203`	`203`	`return parent::fetch($request, $template, $display);`