Harvest seemingly works now, need to update readme and somehow test harvest, add eslint and stuff

Author: Napam

.eslintrc.cjs

@@ -0,0 +1,30 @@
+module.exports = {
+  env: {
+    es2021: true,
+    node: true,
+  },
+  extends: 'eslint:recommended',
+  overrides: [
+    {
+      env: {
+        node: true,
+      },
+      files: ['.eslintrc.{js,cjs}'],
+      parserOptions: {
+        sourceType: 'script',
+      },
+    },
+    {
+      files: ['**/*.test.js'],
+      env: {
+        jest: true,
+      },
+    },
+  ],
+  parserOptions: {
+    ecmaVersion: 'latest',
+    sourceType: 'module',
+  },
+  rules: {},
+  plugins: ['jest'],
+};

cli/configure.js

@@ -84,9 +84,9 @@ const configSchema = yup.object().shape({
  * @param {RawBountyConfig} config
  * @returns {BountyConfig}
  */
-function validateAndProcessBountyConfig(config) {
+export function validateAndProcessBountyConfig(config) {
   try {
-    const validatedConfig = configSchema.validateSync(config);
+    const validatedConfig = { ...configSchema.validateSync(config) };
     validatedConfig.referenceDate = ISODateToDate(config.referenceDate);
     return validatedConfig;
   } catch (error) {
@@ -130,7 +130,7 @@ function validateNumber(input) {
  */
 export async function initalizeBountyConfig() {
   let config = getConfig();
-  let isOldHarvestConfig = config != null && !Boolean(config.integration);
+  let isOldHarvestConfig = config != null && !config.integration;
 
   /** @type {OldHarvestConfig | null} */
   let oldHarvestConfig = null;
@@ -247,18 +247,18 @@ export async function initalizeBountyConfig() {
     validate: validateNumber,
   });
 
-  const defualtHoursOnChristmasEve = 3.75;
+  const defaultHoursOnChristmasEve = 3.75;
   const { hoursOnChristmasEve } = await inquirer.prompt({
     type: 'input',
     name: 'hoursOnChristmasEve',
-    message: `Enter expected registered hours on Christmas Eve (Julaften, 24. December) (float, default ${defualtHoursOnChristmasEve}):`,
-    default: defualtHoursOnChristmasEve,
+    message: `Enter expected registered hours on Christmas Eve (Julaften, 24. December) (float, default ${defaultHoursOnChristmasEve}):`,
+    default: defaultHoursOnChristmasEve,
     validate: validateNumber,
   });
 
   config.hoursOnSpecificHolidays = {
-    [NorwegianHoliday.HOLY_WEDNESDAY]: hoursOnHolyWednesday,
-    [NorwegianHoliday.CHRISTMAS_EVE]: hoursOnChristmasEve,
+    [NorwegianHoliday.HOLY_WEDNESDAY]: parseFloat(hoursOnHolyWednesday),
+    [NorwegianHoliday.CHRISTMAS_EVE]: parseFloat(hoursOnChristmasEve),
   };
 
   const validatedconfig = validateAndProcessBountyConfig(config);

integrations/harvest/configuration.js

@@ -34,7 +34,7 @@ export async function setupFilesInHomeAndPromptForInfo() {
 
   setConfig(currConfig);
   console.log();
-  console.log(`Config \x1b[32msuccessfully\x1b[m updated at \x1b[33m${CONFIG_FILE}\x1b[m`);
+  console.log(`Harvest config \x1b[32msuccessfully\x1b[m updated at \x1b[33m${CONFIG_FILE}\x1b[m`);
   console.log();
   console.log(`If something crashes, make sure that the config values makes sense:`);
   console.log(currConfig);
@@ -43,11 +43,18 @@ export async function setupFilesInHomeAndPromptForInfo() {
   return currConfig;
 }
 
+/** @type {ClockifyConfig | null} */
+let config = null;
+
 /**
  * @returns {HarvestConfig}
  */
 export function getConfig() {
-  return JSON.parse(fs.readFileSync(CONFIG_FILE).toString());
+  if (config != null) {
+    return config;
+  }
+  config = JSON.parse(fs.readFileSync(CONFIG_FILE).toString());
+  return config;
 }
 
 export function setConfig(config) {

integrations/harvest/index.js

@@ -1,5 +1,8 @@
 import * as dates from '../../core/dates.js';
 import { setupFilesInHomeAndPromptForInfo } from './configuration.js';
+import { CONFIG_FILE } from './constants.js';
+import axios from 'axios';
+import { getConfig as getCoreConfig, validateAndProcessBountyConfig } from '../../cli/configure.js';
 
 /**
  * @param {object} headers headers to send to harvest
@@ -52,19 +55,10 @@ export async function getWorkHours(from, to) {
  * @param {{to: Date, from: Date , balance: number}} obj
  * */
 export async function afterRun({ balance }) {
-  console.log('referenceDate :>> ', getReferenceDate().toLocaleDateString('no-NB'));
-  console.log('referenceBalance :>> ', getReferenceBalance());
+  const coreConfig = validateAndProcessBountyConfig(getCoreConfig());
+
+  console.log('referenceDate :>> ', coreConfig.toLocaleDateString('no-NB'));
+  console.log('referenceBalance :>> ', coreConfig.referenceBalance);
   console.log('currDate :>> ', new Date().toLocaleDateString('no-NB'));
   console.log('currBalance :>> ', balance);
 }
-
-import { fileURLToPath } from 'url';
-if (process.argv[1] === fileURLToPath(import.meta.url)) {
-  async function main() {
-    await beforeRun();
-    const workedHours = await getWorkHours();
-    console.log('workedHours :>> ', workedHours);
-  }
-
-  main();
-}