Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev: please document the Debian package and stop installing src/tools/ #795

Open
asarhaddon opened this issue Feb 11, 2025 · 1 comment
Open

dev: please document the Debian package and stop installing src/tools/ #795

asarhaddon opened this issue Feb 11, 2025 · 1 comment
Labels
enhancement New feature or request

Comments

@asarhaddon
Copy link
Contributor

Hello.

docs/INSTALLATION.md should probably recommend the .deb distributed by Debian instead of the generic stuff produced by make deb. It should provide a better experience to end users because it is maintained by humans (and robots, for example with regular rebuild tests). The changes that I have recently suggested for the desktop file are a good example.

If a contributor wants to build a local .deb, they should clone https://salsa.debian.org/debian/nanovna-saver/ (a fork adding the debian/ subdirectory) and run gbp buildpackage.

As far as I can see (I am using pyproject.toml, not Astral UV), src/tools/ is installed into the wheel alongside src/NanoVNASaver/. This is probably unwanted, as this directory is only used at build time and its name is too generic for system-wide installation.
@asarhaddon asarhaddon added the enhancement New feature or request label Feb 11, 2025
@barjac
Copy link

barjac commented Feb 13, 2025 •
edited
Loading

+1 to the src/tools part

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@barjac @asarhaddon