Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nanovna-saver.py missing from repo? #788

Open
underdog opened this issue Feb 7, 2025 · 9 comments
Open

nanovna-saver.py missing from repo? #788

underdog opened this issue Feb 7, 2025 · 9 comments

Comments

@underdog
Copy link

underdog commented Feb 7, 2025

Describe the bug
I have looked at the instructions many times and have seen reference to nanovna-saver.py, even on the one regarding running without install. it appears this file is missing from the repo. maybe it was there at the time of writing, but it doesn't exist anymore. are there updated instructions on running without install?

To Reproduce
Steps to reproduce the behavior:

  1. look at repo, file is missing

Expected behavior
Expect nanovna-saver.py file to exist in repo

Screenshots
N/A

Desktop (please complete the following information):
Repo related, not OS related

Additional context
None

@zarath
Copy link
Collaborator

zarath commented Feb 7, 2025

Is it still mentioned in the instructions?

uv sync && uv run task ui-compile && uv run NanoVNASaver

should work

@underdog
Copy link
Author

underdog commented Feb 7, 2025

Is it still mentioned in the instructions?

uv sync && uv ui-compile && uv run NanoVNASaver

should work

will give it a go

@underdog
Copy link
Author

underdog commented Feb 7, 2025

Is it still mentioned in the instructions?

uv sync && uv ui-compile && uv run NanoVNASaver

should work

so will this change the homebrew instructions also? I'm using brew also and I found that NanoVNASaver.py in the src directory, but it is going to fail because that's not the configured py file

@zarath
Copy link
Collaborator

zarath commented Feb 7, 2025

I don't use brew, but

brew install uv

and then previous instructions?

@underdog
Copy link
Author

underdog commented Feb 7, 2025

uv ui-compile won't work. there is a ui_compile.py in the src/ directory. seems that the current repo has had some changes for instructions. maybe I'll wait for instructions to be updated.

@zarath
Copy link
Collaborator

zarath commented Feb 7, 2025

Ok. Misstyped be me.

uv run task ui-compile

@underdog
Copy link
Author

underdog commented Feb 7, 2025

Ok. Misstyped be me.

uv run task ui-compile

awesome...ok, that worked now..the UI came up after running the task compile command and then the run command

@redrathnure
Copy link
Contributor

@zarath WDYT about just publish the python package to the PyPi repo? It would simplify answer to this and similar questions, like pipx install nanovna-saver then just exec nanovna-saver. uv is lightware and fast, however I am not sure "regular" users need to install whole build chain.

@zarath
Copy link
Collaborator

zarath commented Feb 7, 2025

As soon as I have time and need :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants