-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(box): file sync #235
base: main
Are you sure you want to change the base?
feat(box): file sync #235
Conversation
integrations/box/syncs/files.ts
Outdated
name: metadata.name, | ||
modified_at: metadata.modified_at, | ||
download_url: metadata.shared_link?.download_url, | ||
field_id: metadata.id |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is the field_id
used for / why is this included?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is to help the user understand that that the field_id in the api docs is the same as the id field
integrations/box/syncs/files.ts
Outdated
let batch: BoxDocument[] = []; | ||
const batchSize = 100; | ||
|
||
const response = await nango.get<ListFolderItemsResponse>(proxy); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't actually paginate over the results, should use nango.paginate
Describe your changes
files
sync.Challenges
--save-responses
flag does not work withresponseType: 'stream'
when generating tests-m
flag when generating tests does not work correctly. The metadata needs to be set on the connectionIssue ticket number and link
Checklist before requesting a review (skip if just adding/editing APIs & templates)
retries
nango.paginate
call is used instead of awhile (true)
loopnango.yaml
hasauto_start: false
full
sync thentrack_deletes: true
is set