Temp files not cleaned up

[apitzele]

Description

I have a microservice implemented with Nancy and OWIN. The service's responsibility is to accept files and write them to blob storage. When the request is over a certain size, Nancy writes the file to disk in a temp directory. Occasionally these .tmp files fail to get cleaned up.

@grumpydev mentioned on the stack link below that this issue hasn't been seen in awhile but we are on clinteastwood so it looks like the issue hasn't been completly resolved.

https://stackoverflow.com/questions/44847409/nancy-owin-service-fabric-microservice-writes-requests-to-temp-file/44847845#44847845

Steps to Reproduce

I have not been able to reproduce this issue on demand.

System Configuration

We are seeing this problem in our Service Fabric clusters which host Nancy via OWIN

• Nancy version:
  2.0.0-clinteastwood

• Nancy host

  • ASP.NET
  • OWIN
  • Self-Hosted
  • Other:

• Environment (Operating system, version and so on):
  Windows Server

• .NET Framework version:
  4.5.2

• Additional information:

[xt0rted]

These are the related issues around the temp file cleanup that was added to 2.0 #2159, #2430, and #2512.

[apitzele]

Those 3 PRs would have been merged into either clinteastwood, barneyrubble or the alpha releases. I can confirm we've been using clinteastwood since March and are still seeing the behavior.

[danbarua]

I've since moved to a new job so I'm not suffering from the temp file issue any more myself, and I didn't have any luck resolving the issue. We were on OWIN so we could swap RequestStream for RecyclableMemoryStream.

[thecodejunkie]

Any additional info on how we could (reliably?) reproduce this?