Greedy Route capturing too much within the DynamicDictionary when defining multiple routes that are Greedy.

[06b]

Prerequisites

• I have written a descriptive issue title
• I have verified that I am running the latest version of Nancy
• I have verified if the problem exist in both DEBUG and RELEASE mode
• I have searched open and closed issues to ensure it has not already been reported

Description

The DynamicDictionary captures too much when using the Greedy Route when defining multiple routes that are greedy.

Steps to Reproduce

Request: "http://localhost/page/1/hello"
Route template "/{captureseg?}/{greedy_}"
captureseg = "page"
greedy = "1/hello"
*This seems correct_

Request: "http://localhost/page/1"
Route template "/{captureseg?}/{greedy_}"
captureseg = "page"
greedy = "1"
*This seems correct_

Request: "http://localhost/page/"
Route template "/{captureseg?}/{greedy_}"
captureseg = ""
greedy = "page"
_This is expected due to what #1534 reports (Side Note: Duplicate bug #1573), so I'll assume this is correct behavior as of right now*

Now for what I've noticed.

        Get["/test/{captureseg?}/{greedy*}"] = _ =>
        {
                var captureseg = _.captureseg;
                var greedy = _.greedy;
        }

Request: "http://localhost/test/page/"
captureseg = ""
greedy = "test/page" * Expected page not test/page*

Request: "http://localhost/test/something/page/123"
captureseg = "something"
greedy = "page/123" Greedy segment works as expected

However if add a default value to optional capture segments such as below

        Get["/test/{captureseg?helloworld}/{greedy*}"] = _ =>
        {
                var captureseg = _.captureseg;
                var greedy = _.greedy;
        }

Request: "http://localhost/test/page/"
captureseg = "helloworld"
greedy = "page" Now the greedy segment works as expected

Request: "http://localhost/test/hello/page/123"
captureseg = "hello"
greedy = "page/123" Greedy segment works as expected

System Configuration

• Nancy version:
• Nancy host
  • ASP.NET
  • OWIN
  • Self-Hosted
  • Other:
• Other Nancy packages and versions:
• Environment (Operating system, version and so on):
• .NET Framework version:
• Additional information:

Still need to complete editing this issue with the updated issue template.

[TheBunyip]

+1 on this. It's broken right now. If you define the following two routes

Get["/html/{file*}"]
Get["/{file*}"]

And then submit a request to /html/something then it is handled by the first route (as expected) but the value of file is html/something where I expected it to be just something.

Since I don't have a segment before the greedy file segment I can't use @06b's hack above to get around the problem.

[06b]

@TheBunyip - So interesting enough I started experimenting and noticed that if you have only 1 greedy route then the DynamicDictionary appears to work fine. For example If you requested /html/something and you only had one Route as Get["/html/{file*}] then the value of file should render as something

Once you add the second route that's when it starts to act up. On that note - It appears that once you have another route that's a greedy route that the order of the routes appearing seem to be an issue.

For example if you have two routes defined as so
Get["/{file_}"]
Get["/html/{file_}"]
Then the issue goes away (at least while I was experimenting with it).. I don't remember if there is documentation stating that the order of routes matter - so I don't know if this is considered a bug still or if it's "as-designed".