Skip to content

Commit b88f128

Browse files
bobekjanjgarver
authored andcommitted
fix(DisplayDeviceTreeHelperLib): avoid using DeviceTreeHelperLib
Do not use DeviceTreeCheckNodeSingleCompatibility when searching for simple-framebuffer DT nodes. This function requires the nodes' status to be "okay", but simple-framebuffer nodes are intentionally disabled; UEFI should enable them when display is up. Signed-off-by: Jan Bobek <[email protected]>
1 parent f433574 commit b88f128

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

Silicon/NVIDIA/Library/DisplayDeviceTreeHelperLib/DisplayDeviceTreeHelperLib.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/** @file
22
*
3-
* SPDX-FileCopyrightText: Copyright (c) 2023-2024, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
3+
* SPDX-FileCopyrightText: Copyright (c) 2023-2025, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
44
*
55
* SPDX-License-Identifier: BSD-2-Clause-Patent
66
*
@@ -9,7 +9,6 @@
99
#include <PiDxe.h>
1010

1111
#include <Library/DebugLib.h>
12-
#include <Library/DeviceTreeHelperLib.h>
1312
#include <Library/DisplayDeviceTreeHelperLib.h>
1413
#include <Library/PrintLib.h>
1514

@@ -443,7 +442,8 @@ UpdateDeviceTreeSimpleFramebufferInfo (
443442

444443
NodeCount = 0;
445444
fdt_for_each_subnode (NodeOffset, DeviceTree, Result) {
446-
if (EFI_ERROR (DeviceTreeCheckNodeSingleCompatibility ("simple-framebuffer", NodeOffset))) {
445+
Result = fdt_node_check_compatible (DeviceTree, NodeOffset, "simple-framebuffer");
446+
if (Result != 0) {
447447
continue;
448448
}
449449

Silicon/NVIDIA/Library/DisplayDeviceTreeHelperLib/DisplayDeviceTreeHelperLib.inf

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/** @file
22
*
3-
* SPDX-FileCopyrightText: Copyright (c) 2023-2024 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
3+
* SPDX-FileCopyrightText: Copyright (c) 2023-2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
44
*
55
* SPDX-License-Identifier: BSD-2-Clause-Patent
66
*
@@ -24,6 +24,5 @@
2424

2525
[LibraryClasses]
2626
DebugLib
27-
DeviceTreeHelperLib
2827
FdtLib
2928
PrintLib

0 commit comments

Comments
 (0)