Skip to content

fix: More heading levels so RNs resolve links #1228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

mikemckiernan
Copy link
Member

@mikemckiernan mikemckiernan commented Jun 12, 2025

Description

We need to increase the number of heading levels that are possible targets so that the RNs can link to the headings.

This fixes a goof in the RNs where the "Added the rails.output.apply_to_reasoning_traces field" bullet did not end with a link at all.

Related Issue(s)

Checklist

  • I've read the CONTRIBUTING guidelines.
  • I've updated the documentation if applicable.
  • I've added tests if applicable.
  • @mentions of the person or team responsible for reviewing proposed changes.

@mikemckiernan mikemckiernan self-assigned this Jun 12, 2025
@mikemckiernan mikemckiernan added the documentation Improvements or additions to documentation label Jun 12, 2025
@mikemckiernan mikemckiernan added this to the v0.15.0 milestone Jun 12, 2025
Copy link

Documentation preview

https://nvidia.github.io/NeMo-Guardrails/review/pr-1228

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.65%. Comparing base (5a4733f) to head (0176574).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1228   +/-   ##
========================================
  Coverage    68.65%   68.65%           
========================================
  Files          161      161           
  Lines        15978    15978           
========================================
  Hits         10969    10969           
  Misses        5009     5009           
Flag Coverage Δ
python 68.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mikemckiernan mikemckiernan requested a review from cparisien June 12, 2025 19:40
@mikemckiernan mikemckiernan requested a review from tgasser-nv June 12, 2025 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants