Support extra properties in ExecEnv #3672
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/build |
ZiyueXu77
approved these changes
Sep 9, 2025
|
/build |
chesterxgchen
approved these changes
Sep 9, 2025
chesterxgchen
pushed a commit
to chesterxgchen/NVFlare
that referenced
this pull request
Sep 30, 2025
Fixes # . ### Description This PR adds following enhancement: - Currently, each type of ExecEnv (Sim, POC, Prod) has a fixed set of properties. However, some recipes may have their own env properties. For example, the EdgeFedBuffRecipe could use device simulation. The config of device simulation belongs to env. This PR makes it possible for specifying extra properties in all types of ExecEnv. - Renamed some recipes to follow common naming convention: EdgeRecipe => EdgeFedBuffRecipe; ETRecipe => ETFedBuffRecipe. The new names contain the training algorithm name (FedBuff). ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [ ] New tests added to cover the changes. - [ ] Quick tests passed locally by running `./runtest.sh`. - [ ] In-line docstrings updated. - [ ] Documentation updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # .
Description
This PR adds following enhancement:
Currently, each type of ExecEnv (Sim, POC, Prod) has a fixed set of properties. However, some recipes may have their own env properties. For example, the EdgeFedBuffRecipe could use device simulation. The config of device simulation belongs to env. This PR makes it possible for specifying extra properties in all types of ExecEnv.
Renamed some recipes to follow common naming convention: EdgeRecipe => EdgeFedBuffRecipe; ETRecipe => ETFedBuffRecipe. The new names contain the training algorithm name (FedBuff).
Types of changes
./runtest.sh.