You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When NWMv3_Forcing_Engine_BMI_model.finalize() is called, the instance variables: _WrfHydroGeoMeta, _inputForcingMod, and _suppPcpMod should be destroyed. This is to ensure their destructors are not called after MPI_Finalize has been called elsewhere (specifically in relation to NOAA-OWP/ngen#748).
Current behavior
NWMv3_Forcing_Engine_BMI_model.finalize only clears scratch files and unsets the instance's model reference.
Expected behavior
NWMv3_Forcing_Engine_BMI_model.finalize should have:
When
NWMv3_Forcing_Engine_BMI_model.finalize()
is called, the instance variables:_WrfHydroGeoMeta
,_inputForcingMod
, and_suppPcpMod
should be destroyed. This is to ensure their destructors are not called afterMPI_Finalize
has been called elsewhere (specifically in relation to NOAA-OWP/ngen#748).Current behavior
NWMv3_Forcing_Engine_BMI_model.finalize
only clears scratch files and unsets the instance's model reference.Expected behavior
NWMv3_Forcing_Engine_BMI_model.finalize
should have:in its body.
The text was updated successfully, but these errors were encountered: