Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8pt] Get Samples broken after new lidar bridges system #1443

Open
RobHanna-NOAA opened this issue Feb 25, 2025 · 1 comment · May be fixed by #1452
Open

[8pt] Get Samples broken after new lidar bridges system #1443

RobHanna-NOAA opened this issue Feb 25, 2025 · 1 comment · May be fixed by #1452
Assignees
Labels
bug Something isn't working

Comments

@RobHanna-NOAA
Copy link
Contributor

Currently we have a PR / branch that is WIP for adding lidar bridges. A quick test against that branch for now, shows that get_sample_data is now broken.

It appears that it might just be a matter of adjusting some of the variable names and possibly adding a few more to the get_sample_data file.

The inline code variables that need to be added or adjusted: (from os.enviro / bash_variables.env)

  • Remove: bathymetry_file

  • Add: bathy_file_ehydro, bathy_file_aibased, and mannN_file_aibased

  • Add (from lidar bridges): input_bridge_elev_diff, input_bridge_elev_diff_alaska

  • Adjust: Was simply osm_bridges and is now osm_bridges and osm_bridges_alaska

@RobHanna-NOAA RobHanna-NOAA added the bug Something isn't working label Feb 25, 2025
@mluck mluck self-assigned this Mar 6, 2025
@mluck
Copy link
Contributor

mluck commented Mar 6, 2025

The PR for adding lidar bridge elevations is now #1406.

@mluck mluck linked a pull request Mar 6, 2025 that will close this issue
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants