Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8pt] Benchmark flow file is incomplete #1434

Open
CarsonPruitt-NOAA opened this issue Feb 18, 2025 · 1 comment
Open

[8pt] Benchmark flow file is incomplete #1434

CarsonPruitt-NOAA opened this issue Feb 18, 2025 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@CarsonPruitt-NOAA
Copy link
Collaborator

The flow file for BLE HUC 11140103 is missing the feature_id 707084. The area of this error has diverging flowpaths, which could be contributing to the issue. We should take another look at the algorithm used to make the flow files to make sure that this doesn't happen elsewhere.

Image

@mluck
Copy link
Contributor

mluck commented Mar 6, 2025

The algorithm currently fills in flow files for segments only where the flow can be exactly computed, i.e.:

  • the upstream flow is the sum of the flows in all segments immediately upstream
  • the downstream flow is the flow in the segment immediately downstream
  • if both the upstream and downstream flows exist, the assigned flow is the mean of the upstream and downstream flow
  • no flow is assigned in other cases such as in this issue where the flow diverges

@mluck mluck self-assigned this Mar 6, 2025
@mluck mluck added the bug Something isn't working label Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants