-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
As a user, I don't want to run into errors when updating the application when offline #669
Comments
It may be worth discussing whether we should move to editable mode as a general expectation for deployments, development or otherwise. I'm not sure I like it, but it would make certain things simpler. Assuming we don't expect that for every deployment, I prefer not to use editable mode with DMOD's current multi-package setup. I think it's better to require ourselves to have the packages we use installed the same way for development as they will be for deployments. I see it as worth the small extra overhead, though I'm open to alternative ideas if there's a more convenient way to ensure we have this kind of environmental consistency for testing. Regardless, I agree we should support at least some development activity without an active Internet connection. This may be another sign that we need to (eventually) not have a bunch of individual packages like this all within the same repository, so we can potentially have that conversation as well (though perhaps in a different issue). |
Im fairly certain this is unavoidable because of how we specify / need to specify several dependencies. To my best knowledge, |
This pertains to ./scripts/update_package.sh
My internet went down this morning and I needed to update my codebase so all my changes were in place so I could test.
With everything already available locally (including all remote sources), I ran into issues like:
An internet connection should not be required 100% of the time just to develop.
Either handling needs to be added to avoid having to call
pip
whenever moving code into the virtual environment orupdate_script.sh
needs to be updated to 'install' in edit mode where packages don't need to be in the virtual environment to begin with.The text was updated successfully, but these errors were encountered: