Makefile.in: build config.h before any object #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Object files lack dependency on `config.h` symlink (and usually depend
only on `ldns/config.h`). As a result build occasionally fails in
`make --shuffe mode`:
$ make --shuffle
...
./libtool --tag=CC --quiet --mode=compile gcc -I. -I. \
-DHAVE_CONFIG_H -DLDNS_TRUST_ANCHOR_FILE="\"...-dns-root-data-2019-01-11/root.key\"" \
-DOPENSSL_API_COMPAT=10100 -fno-strict-aliasing -Wunused-function -Wstrict-prototypes \
-Wwrite-strings -W -Wall -g -O2 -I...-openssl-3.0.7-dev/include -c examples/ldns-rrsig.c \
-o examples/ldns-rrsig.o
examples/ldns-rrsig.c:10:10: fatal error: config.h: No such file or directory
10 | #include "config.h"
| ^~~~~~~~~~
The change moves `config.h` symlink creation in `setup-builddir` from
a dependency on final binary to dependency on all individual objects.
While at it regenerated dependencies with `make depend`.
before the change `make --shuffle` build was failing in about 50% cases.
After the change: `make --shuffle` succeeded 80 times in a row.
wtoorop
approved these changes
Jul 12, 2024
|
Oh, I just noticed you have reverted the change. I still see the build failures on the current |
|
Yes, I did reverse it and I was a bit in a hurry, so failed to tell you about it. |
|
Aha, the broken incremental rebuild makes sense. I remember it being the problem. But I had an impression that it's not a new behaviour and incremental rebuild is already happening on unmodified |
|
Wow, you have an impressively fast machine, but are you sure you did git pull? With me the second time the object files are not rebuild: Anyway, I will do the release now, but don't worry, we'll put it in the next release if we can find a way to make make --shuffle work. And a next release doesn't need to take another 2 years. |
|
Also, what options to configure did you use to get the 51 libtool invokes? |
|
Oh, I'm using Here is my full session: git update$ libtoolize -ci && autoreconf -fi./configurefirst makesecond make (with logs) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Object files lack dependency on
config.hsymlink (and usually depend only onldns/config.h). As a result build occasionally fails inmake --shuffe mode:The change moves
config.hsymlink creation insetup-builddirfrom a dependency on final binary to dependency on all individual objects.While at it regenerated dependencies with
make depend.before the change
make --shufflebuild was failing in about 50% cases.After the change:
make --shufflesucceeded 80 times in a row.