-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
repository_request with tag should result in repository_response with tag #984
Comments
Yeah, you're right. It should be echo-ed even if Krill doesn't really use it. The issue with this is state tracking. The response you get is independent from that request in reality. The server accepted the publisher, but the handle in that response is made up by the server. We could track the last known tag, but it's a bit of a hassle.. or have the api ignore previously seen requests and just echo whatever the tag-du-jour is in the response then.. Point is.. it's a bit of work. Can it wait a bit? |
It can definitely wait. I think the tag probably should be handled the same way as the publisher_handle. Is that also generated ad hoc? |
Any update on this issue? We have a related issue open internally :) |
No update. I moved it to the bottom of the todo column for this release - I may be able to work on it while the code for improving the storage layer is being reviewed. |
After reading about tags, I tried to upload the following
repository_request
totestbed.krill.cloud
:This gave this response:
Expected behavior:
Identical "tag" attribute is present in the response (81813#5.2.4)
Observed behavior:
Tag is not present in response
The text was updated successfully, but these errors were encountered: