Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test basic_login_session_cache_test is flakey #1157

Open
ximon18 opened this issue Nov 15, 2023 · 1 comment
Open

Test basic_login_session_cache_test is flakey #1157

ximon18 opened this issue Nov 15, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@ximon18
Copy link
Member

ximon18 commented Nov 15, 2023

From: https://github.com/NLnetLabs/krill/actions/runs/6508984037/job/17679444611#step:5:882

---- daemon::auth::common::session::tests::basic_login_session_cache_test stdout ----
thread 'daemon::auth::common::session::tests::basic_login_session_cache_test' panicked at src/daemon/auth/common/session.rs:332:9:
assertion `left == right` failed
  left: 0
 right: 1
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

This failed in a test run in which the changes made seem unrelated to the failure.

@ximon18
Copy link
Member Author

ximon18 commented Nov 15, 2023

The test is dependent on elapsed time which in a CI environment with slower and shared-tenancy machines is going to be unreliable. A proper fix will require removing the dependence on elapsed time.

@timbru timbru added the bug Something isn't working label Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

No branches or pull requests

2 participants