Per best practice don't permit PKCS#11 private keys to be modified (fixes #1018). #1020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ximon18
added
enhancement
timbru
approved these changes
Mar 2, 2023
|
Per the discussion on #1018 I'll re-work this PR to give operators control over key attributes rather than assume in Krill that we know what the best defaults / hard-coded values are. |
…ibutes to be overridden (#1018).
|
@timbru: I think these new settings also need mentioning in the HSM part of the Krill manual, but I haven't done that yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This description has been updated following re-work of the PR as described in the comments below)
This PR adds
krill.confconfiguration settings that give operators control (per #1018) over some of the PKCS#11 attributes set on new public and private keys that Krill creates, rather than assume in Krill that we know what the best defaults / hard-coded values are.The existing default behaviour is preserved for backward compatibility, i.e. these new settings do nothing if not used.