Skip to content

Using concurrency and dependencies in package CI #684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
1 task done
esclapez opened this issue Jan 28, 2025 · 1 comment
Open
1 task done

Using concurrency and dependencies in package CI #684

esclapez opened this issue Jan 28, 2025 · 1 comment
Labels
generated-package Related to the generated package, i.e. after running cookiecutter

Comments

@esclapez
Copy link

Checklist before submitting an issue

  • I have checked the existing issues and couldn't find an issue about this bug.

Issue details

I have now used the template a couple of times and I have ended up adding manually:

  • a dependency between the lint and build jobs in the build.yml file
  • a concurrency check in order to cancel concurrent similar jobs from successive push

Both are good practices to reduce wasted runner time. Would it be worth to have those directly in the template ?

@esclapez esclapez added the generated-package Related to the generated package, i.e. after running cookiecutter label Jan 28, 2025
@egpbos
Copy link
Member

egpbos commented Apr 4, 2025

I think the concurrency check is a good default!

I would be a bit more hesitant against lint and build jobs depending on each other, they are really different things. Also, I think it can actually lead to more CI runs. If both linting and testing/building fails separately then we can fix them in one commit (or better: two commits and one push). If you have to wait for one to get fixed before finding out the other also fails you have to do two pushes, and get two CI runs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
generated-package Related to the generated package, i.e. after running cookiecutter
Projects
None yet
Development

No branches or pull requests

2 participants