Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write up more extensive (and more robust) testing #44

Open
Paulj1989 opened this issue Jun 8, 2023 · 0 comments
Open

Write up more extensive (and more robust) testing #44

Paulj1989 opened this issue Jun 8, 2023 · 0 comments
Assignees
Labels
priority: high High priority issue type: enhancement Enhance existing feature

Comments

@Paulj1989
Copy link
Member

Paulj1989 commented Jun 8, 2023

Problem

Code coverage is currently at just below 50%, which is definitely less than ideal! There is a lot of functionality in the app that isn't being tested, and because there are a lot of dependent elements in the app, this could easily lead to small changes making big problems.

Proposed Solution

The code coverage needs to be, at a minimum, over 80%. There needs to be robust testing in place to make sure the data is pulling through as expected, that the app looks as expected when it loads, that typical usage produces consistent results, and that downloaded plots and data are generated correctly.

Additional Context

R packages and Shiny testing overview:

For basic testing of outputs and business logic in the app:

For testing Shiny:

@Paulj1989 Paulj1989 added type: feature request Request new feature status: needs information Further information is requested labels Jun 8, 2023
@Paulj1989 Paulj1989 self-assigned this Jun 8, 2023
@Paulj1989 Paulj1989 added type: enhancement Enhance existing feature priority: high High priority issue and removed type: feature request Request new feature status: needs information Further information is requested labels Jun 9, 2023
@Paulj1989 Paulj1989 linked a pull request Jun 14, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: high High priority issue type: enhancement Enhance existing feature
Projects
None yet
Development

No branches or pull requests

1 participant