Debug the normalizer.py

[SeverusYixin]

some licenses like "bsd 3-clause" not be normalized, check it and update the code.

[SeverusYixin]

Hi @haesleinhuepf,
The original script only normalized the data, while book.yml and test.yml simply called this function without performing additional operations, such as upgrading. For details on the upgrade operation, refer to PR #511

There are two questions:

1. Should the process of creating a pull request (PR) be handled within data_normalizer? Would this approach be safer?

2. Regarding the author fiel:
   e.g. authors: ‘Fabig, Gunar, Jannasch, Anett, Okafornta, Chukwuebuka, Boissonnet, Tom,
   \ Schmidt, Christian, Bortolomeazzi, Michele, Fuchs, Vanessa Aphaia Fiona, Koeckert,
   \ Maria, Poddar, Aayush, Vogel, Martin, Schwarzbach, Hanna-Margareta, Vogelsang,
   Andy, Gerlach, Michael, Nobst, Anja, Müller-Reichert, Thomas, Tulok, Silke’

in line

training/resources/nfdi4bioimage.yml

Line 6935 in 089c26a

- authors: "Fabig, Gunar, Jannasch, Anett, Okafornta, Chukwuebuka, Boissonnet, Tom,\

Was this list generated automatically? How can it add something like ""?

[SeverusYixin]

Also this one "

training/resources/nfdi4bioimage.yml

Line 6300 in 089c26a

- authors: "Ahmadi, Mohsen, Wagner, Robert, Mattern, Philipp, Plathe, Nick, Bekeschus,\

".
How was it added? Why is it so different from the original website format?

[haesleinhuepf]

1. Should the process of creating a pull request (PR) be handled within data_normalizer?

Yes! It would also to easier to read in Python.

How was it added? Why is it so different from the original website format?

Have you tried out git blame? You can click on the line number next to the code and read which commit added the code and who did it. Give it a try!

[SeverusYixin]

1. Should the process of creating a pull request (PR) be handled within data_normalizer?

Yes! It would also to easier to read in Python.

OK :)

How was it added? Why is it so different from the original website format?

Have you tried out git blame? You can click on the line number next to the code and read which commit added the code and who did it. Give it a try!

It looks like automatic add by the zenodo links, then this is a new data format, I will also create a rule for it

[haesleinhuepf]

It looks like automatic add by the zenodo links,

Can you please point me to the code where this happens?

[SeverusYixin]

It looks like automatic add by the zenodo links,

Can you please point me to the code where this happens?

https://github.com/NFDI4BIOIMAGE/training/blame/089c26a86a6625499809be0955ce58977251a757/resources/nfdi4bioimage.yml#L6935

as in this one when you use the git blame, it will show you github-actions[bot].

[haesleinhuepf]

Is there code on our side which adds the author="..." format?

[SeverusYixin]

Is there code on our side which adds the author="..." format?

There are no exactly code!! It just show me as when you give the zenodo link and the github-action will add it, and this problem have already be solved by the latest PR #516

[haesleinhuepf]

How about modifying the script(s) which introduce the wrong format instead of correcting the format later? I think it would be good to write correct stuff into the yaml in the first place.