Minor issues from PR #14 #26
Description
There are a few things we discussed in #14 but didn't address in changes.
I'll list them here to have a reminder.
All of them are, as far as I can tell, minor issues. Mostly style related, so there's no need to work on them immediately. Furthermore some of them came up during the PR but are not related to the main topic so we should separate them anyway.
- https://github.com/NETWAYS/ansible-role-patroni/pull/14/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R76 Some confusion regarding log format. It seems that this needs further investigation.
- https://github.com/NETWAYS/ansible-role-patroni/pull/14/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R91 Some more confusion about api addresses and how to connect to different instances.
- https://github.com/NETWAYS/ansible-role-patroni/pull/14/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R130 Duplicate default. It's set to the same value as a default in two places.
- https://github.com/NETWAYS/ansible-role-patroni/pull/14/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R132 Maybe a duplicate variable. You can set a variable which could also be derived from two other variables.
- Overall the templates use boolean values, have them mentioned but they are not set to a default the usual way. This could be a topic for a complete overhaul.