Skip to content

Fix identifier matching logic when only deviation files are present for combination row #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
6 tasks done
nolanwelch opened this issue Apr 14, 2025 · 0 comments
Open
6 tasks done
Assignees

Comments

@nolanwelch
Copy link
Member

nolanwelch commented Apr 14, 2025

An error is raised for the identifier s2r1 psychopy sub-3000147 due to no files appearing to be present:

Combination row arrow-alert_psychopy has no variables present in /home/data/NDClab/datasets/thrive-dataset/sourcedata/raw/s2_r1/psychopy/sub-3000147/

However, variables are present, but all relevant files are deviation files that contain additional info. The issue lies in how we build the list of present combination identifiers.

Currently, the logic:

  • Loops over all combination rows
  • Then loops over all present sub/ses/run tuples
  • Pulls in identifiers that:
    • Match the combination row
    • Match sub/ses/run
    • Are not deviation files

This means if all relevant identifiers are tied to deviation files, none are matched, causing a false "no variables" error.

Fix Needed:
Rework logic to correctly handle cases where only deviation files are present, possibly by:

  • Adjusting matching logic to include deviation files under certain conditions
  • Adding fallback checks when all matching identifiers are excluded due to deviation status

Checklist:

  • Audit current logic for constructing present combination identifiers
  • Identify and isolate logic excluding deviation files
  • Modify logic to consider deviation files when appropriate
  • Add test case for sub-3000147 scenario (s2r1, psychopy, arrow-alert)
  • Verify fix prevents false "no variables" error
  • Document behavior of deviation files in identifier matching
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant